fsnotify: Use NULL instead of 0 for pointer
diff mbox series

Message ID 1572356342-24776-1-git-send-email-yangtiezhu@loongson.cn
State New
Headers show
Series
  • fsnotify: Use NULL instead of 0 for pointer
Related show

Commit Message

Tiezhu Yang Oct. 29, 2019, 1:39 p.m. UTC
Fix the following sparse warning:

fs/notify/fdinfo.c:53:87: warning: Using plain integer as NULL pointer

Fixes: be77196b809c ("fs, notify: add procfs fdinfo helper")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 fs/notify/fdinfo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jan Kara Oct. 30, 2019, 12:21 p.m. UTC | #1
On Tue 29-10-19 21:39:02, Tiezhu Yang wrote:
> Fix the following sparse warning:
> 
> fs/notify/fdinfo.c:53:87: warning: Using plain integer as NULL pointer
> 
> Fixes: be77196b809c ("fs, notify: add procfs fdinfo helper")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Thanks for the patch but similar patch already sits in my tree as commit
ddd06c36bdb "fsnotify/fdinfo: exportfs_encode_inode_fh() takes pointer as
4th argument". I'll send it to Linus in the next merge window.

								Honza

> ---
>  fs/notify/fdinfo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
> index 1e2bfd2..cd2846e 100644
> --- a/fs/notify/fdinfo.c
> +++ b/fs/notify/fdinfo.c
> @@ -50,7 +50,8 @@ static void show_mark_fhandle(struct seq_file *m, struct inode *inode)
>  	f.handle.handle_bytes = sizeof(f.pad);
>  	size = f.handle.handle_bytes >> 2;
>  
> -	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle, &size, 0);
> +	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle,
> +				       &size, NULL);
>  	if ((ret == FILEID_INVALID) || (ret < 0)) {
>  		WARN_ONCE(1, "Can't encode file handler for inotify: %d\n", ret);
>  		return;
> -- 
> 2.1.0
> 
>
Tiezhu Yang Oct. 30, 2019, 1:12 p.m. UTC | #2
On 10/30/2019 08:21 PM, Jan Kara wrote:
> On Tue 29-10-19 21:39:02, Tiezhu Yang wrote:
>> Fix the following sparse warning:
>>
>> fs/notify/fdinfo.c:53:87: warning: Using plain integer as NULL pointer
>>
>> Fixes: be77196b809c ("fs, notify: add procfs fdinfo helper")
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Thanks for the patch but similar patch already sits in my tree as commit
> ddd06c36bdb "fsnotify/fdinfo: exportfs_encode_inode_fh() takes pointer as
> 4th argument". I'll send it to Linus in the next merge window.
>
> 								Honza

Thanks for your reply. I can not find your tree about fs/notify
in the MAINTAINERS file, so this patch is based on Linus's tree.
Sorry for the noise, you can ignore it.

By the way, could you add your tree in the MAINTAINERS file?

Thanks,

Tiezhu Yang

>
>> ---
>>   fs/notify/fdinfo.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
>> index 1e2bfd2..cd2846e 100644
>> --- a/fs/notify/fdinfo.c
>> +++ b/fs/notify/fdinfo.c
>> @@ -50,7 +50,8 @@ static void show_mark_fhandle(struct seq_file *m, struct inode *inode)
>>   	f.handle.handle_bytes = sizeof(f.pad);
>>   	size = f.handle.handle_bytes >> 2;
>>   
>> -	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle, &size, 0);
>> +	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle,
>> +				       &size, NULL);
>>   	if ((ret == FILEID_INVALID) || (ret < 0)) {
>>   		WARN_ONCE(1, "Can't encode file handler for inotify: %d\n", ret);
>>   		return;
>> -- 
>> 2.1.0
>>
>>
Jan Kara Oct. 30, 2019, 2:10 p.m. UTC | #3
On Wed 30-10-19 21:12:37, Tiezhu Yang wrote:
> On 10/30/2019 08:21 PM, Jan Kara wrote:
> > On Tue 29-10-19 21:39:02, Tiezhu Yang wrote:
> > > Fix the following sparse warning:
> > > 
> > > fs/notify/fdinfo.c:53:87: warning: Using plain integer as NULL pointer
> > > 
> > > Fixes: be77196b809c ("fs, notify: add procfs fdinfo helper")
> > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > Thanks for the patch but similar patch already sits in my tree as commit
> > ddd06c36bdb "fsnotify/fdinfo: exportfs_encode_inode_fh() takes pointer as
> > 4th argument". I'll send it to Linus in the next merge window.
> > 
> > 								Honza
> 
> Thanks for your reply. I can not find your tree about fs/notify
> in the MAINTAINERS file, so this patch is based on Linus's tree.
> Sorry for the noise, you can ignore it.
> 
> By the way, could you add your tree in the MAINTAINERS file?

Good idea! Added. Thanks!

								Honza

> > > ---
> > >   fs/notify/fdinfo.c | 3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
> > > index 1e2bfd2..cd2846e 100644
> > > --- a/fs/notify/fdinfo.c
> > > +++ b/fs/notify/fdinfo.c
> > > @@ -50,7 +50,8 @@ static void show_mark_fhandle(struct seq_file *m, struct inode *inode)
> > >   	f.handle.handle_bytes = sizeof(f.pad);
> > >   	size = f.handle.handle_bytes >> 2;
> > > -	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle, &size, 0);
> > > +	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle,
> > > +				       &size, NULL);
> > >   	if ((ret == FILEID_INVALID) || (ret < 0)) {
> > >   		WARN_ONCE(1, "Can't encode file handler for inotify: %d\n", ret);
> > >   		return;
> > > -- 
> > > 2.1.0
> > > 
> > > 
>

Patch
diff mbox series

diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
index 1e2bfd2..cd2846e 100644
--- a/fs/notify/fdinfo.c
+++ b/fs/notify/fdinfo.c
@@ -50,7 +50,8 @@  static void show_mark_fhandle(struct seq_file *m, struct inode *inode)
 	f.handle.handle_bytes = sizeof(f.pad);
 	size = f.handle.handle_bytes >> 2;
 
-	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle, &size, 0);
+	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle,
+				       &size, NULL);
 	if ((ret == FILEID_INVALID) || (ret < 0)) {
 		WARN_ONCE(1, "Can't encode file handler for inotify: %d\n", ret);
 		return;