[v2,1/4] dt-bindings: leds: Document commonly used LED triggers
diff mbox series

Message ID 20191030090124.24900-2-manivannan.sadhasivam@linaro.org
State New
Headers show
Series
  • Add support for Thor96 board
Related show

Commit Message

Manivannan Sadhasivam Oct. 30, 2019, 9:01 a.m. UTC
This commit documents the LED triggers used commonly in the SoCs. Not
all triggers are documented as some of them are very application specific.
Most of the triggers documented here are currently used in devicetrees
of many SoCs.

Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 .../devicetree/bindings/leds/common.txt         | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Rob Herring Nov. 5, 2019, 10:04 p.m. UTC | #1
On Wed, Oct 30, 2019 at 02:31:21PM +0530, Manivannan Sadhasivam wrote:
> This commit documents the LED triggers used commonly in the SoCs. Not
> all triggers are documented as some of them are very application specific.
> Most of the triggers documented here are currently used in devicetrees
> of many SoCs.

I guess it's worth documenting these, but you plan to use 'function' 
instead, right?

> 
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  .../devicetree/bindings/leds/common.txt         | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> index 9fa6f9795d50..2a6806161590 100644
> --- a/Documentation/devicetree/bindings/leds/common.txt
> +++ b/Documentation/devicetree/bindings/leds/common.txt
> @@ -55,6 +55,23 @@ Optional properties for child nodes:
>       "timer" - LED flashes at a fixed, configurable rate
>       "pattern" - LED alters the brightness for the specified duration with one
>                   software timer (requires "led-pattern" property)
> +     "mmc[N]" - LED indicates [N]th MMC storage activity
> +     "flash" - LED indicates camera flash state
> +     "torch" - LED indicates camera torch state
> +     "audio-mute" - LED indicates audio mute state
> +     "audio-micmute" - LED indicates mic mute state
> +     "bluetooth-power" - LED indicates bluetooth power state
> +     "usb-gadget" - LED indicates USB gadget activity
> +     "usb-host" - LED indicates USB host activity
> +     "mtd" - LED indicates MTD memory activity
> +     "nand-disk" - LED indicates NAND memory activity (deprecated),
> +                  in new implementations use "mtd"
> +     "disk-read" - LED indicates disk read activity
> +     "disk-write" - LED indicates disk write activity
> +     "none" - No trigger assigned to the LED. This is the default mode
> +              if trigger is absent
> +     "cpu" - LED indicates activity of all CPUs
> +     "cpu[N]" - LED indicates activity of [N]th CPU
>  
>  - led-pattern : Array of integers with default pattern for certain triggers.
>                  Each trigger may parse this property differently:
> -- 
> 2.17.1
>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
index 9fa6f9795d50..2a6806161590 100644
--- a/Documentation/devicetree/bindings/leds/common.txt
+++ b/Documentation/devicetree/bindings/leds/common.txt
@@ -55,6 +55,23 @@  Optional properties for child nodes:
      "timer" - LED flashes at a fixed, configurable rate
      "pattern" - LED alters the brightness for the specified duration with one
                  software timer (requires "led-pattern" property)
+     "mmc[N]" - LED indicates [N]th MMC storage activity
+     "flash" - LED indicates camera flash state
+     "torch" - LED indicates camera torch state
+     "audio-mute" - LED indicates audio mute state
+     "audio-micmute" - LED indicates mic mute state
+     "bluetooth-power" - LED indicates bluetooth power state
+     "usb-gadget" - LED indicates USB gadget activity
+     "usb-host" - LED indicates USB host activity
+     "mtd" - LED indicates MTD memory activity
+     "nand-disk" - LED indicates NAND memory activity (deprecated),
+                  in new implementations use "mtd"
+     "disk-read" - LED indicates disk read activity
+     "disk-write" - LED indicates disk write activity
+     "none" - No trigger assigned to the LED. This is the default mode
+              if trigger is absent
+     "cpu" - LED indicates activity of all CPUs
+     "cpu[N]" - LED indicates activity of [N]th CPU
 
 - led-pattern : Array of integers with default pattern for certain triggers.
                 Each trigger may parse this property differently: