common/rc: fix _require_xfs_io_command utimes check
diff mbox series

Message ID 20191031012553.72731-1-lubaihua0331@gmail.com
State New
Headers show
Series
  • common/rc: fix _require_xfs_io_command utimes check
Related show

Commit Message

Baihua Lu Oct. 31, 2019, 1:25 a.m. UTC
There is an error on checking utimes command. Put quotation mark after four "0".

Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Darrick J. Wong Oct. 31, 2019, 3:41 a.m. UTC | #1
On Thu, Oct 31, 2019 at 01:25:53AM +0000, Baihua Lu wrote:
> There is an error on checking utimes command. Put quotation mark after four "0".
> 
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>

Looks ok to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index a2a28f32..657d05d3 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2186,7 +2186,7 @@ _require_xfs_io_command()
>  			_notrun "xfs_io $command support is missing"
>  		;;
>  	"utimes" )
> -		testio=`$XFS_IO_PROG -f -c "utimes" 0 0 0 0 $testfile 2>&1`
> +		testio=`$XFS_IO_PROG -f -c "utimes 0 0 0 0" $testfile 2>&1`
>  		;;
>  	"syncfs")
>  		touch $testfile
> -- 
> 2.17.1
>

Patch
diff mbox series

diff --git a/common/rc b/common/rc
index a2a28f32..657d05d3 100644
--- a/common/rc
+++ b/common/rc
@@ -2186,7 +2186,7 @@  _require_xfs_io_command()
 			_notrun "xfs_io $command support is missing"
 		;;
 	"utimes" )
-		testio=`$XFS_IO_PROG -f -c "utimes" 0 0 0 0 $testfile 2>&1`
+		testio=`$XFS_IO_PROG -f -c "utimes 0 0 0 0" $testfile 2>&1`
 		;;
 	"syncfs")
 		touch $testfile