PATCH: Change log level of "iwlwifi 0000:6f:00.0: BIOS contains WGDS but no WRDS" to "info"
diff mbox series

Message ID 30e95fb1-96df-b96a-c79e-e35a945ec889@computerix.info
State New
Delegated to: Luca Coelho
Headers show
Series
  • PATCH: Change log level of "iwlwifi 0000:6f:00.0: BIOS contains WGDS but no WRDS" to "info"
Related show

Commit Message

Klaus Kusche Oct. 31, 2019, 10:30 a.m. UTC
Hello again,

On 22/10/2019 20:39, Klaus Kusche wrote:
> Hello,
> 
> every time I boot my dell notebook (with Wi-Fi 6 AX200), I get the error message 
> "iwlwifi 0000:6f:00.0: BIOS contains WGDS but no WRDS".
> 
> This is the only message which such a high log level I get while booting,
> it is the only message which is displayed on all text consoles on boot,
> and it is the only message which makes my automated logchecker nervous each time.
> 
> However, iwlwifi works perfectly fine for wifi in spite of the message
> (and bluetooth has deliberately been disabled in the bios settings
> for security reasons),
> and there is absolutely nothing I could do about the message
> (I have no influence what dell does in their bios and what they don't).
> Internet wisdom also says that the message is just annoying and
> can be safely ignored.
> 
> Hence, the message is not an error at all ("error" being defined as
> "something definitely failed, manual intervention required for correct operation").
> It does not even qualify as a warning ("warning" being defined as
> "something is likely to fail, manual checking recommended").
> 
> So please set the log level of that message down to "info"
> (besides, the message text is completely cryptic and uninformative,
> I still don't know what this message wants to tell me,
> although I searched the internet).

Discussed this with Mario.Limonciello@dell.com.
He also wants this to be patched:

On 29/10/2019 22:43, Mario.Limonciello@dell.com wrote:
> Dell Customer Communication - Confidential
> 
>> -----Original Message-----
>> From: Klaus Kusche <klaus.kusche@computerix.info>
>>...
>> When booting, there is a single kernel message of loglevel error
>> which stands out in red in journalctl
>> and which gets displayed on all text consoles (very annoying):
>>
>> kernel: iwlwifi 0000:6f:00.0: BIOS contains WGDS but no WRDS
> 
> If possible, you should probably submit a patch to iwlwifi driver to downgrade this message to
> debug.  It really isn't useful to many people typically.

So here comes a patch:

Comments

Kalle Valo Oct. 31, 2019, 1 p.m. UTC | #1
Klaus Kusche <klaus.kusche@computerix.info> writes:

> Hello again,
>
> On 22/10/2019 20:39, Klaus Kusche wrote:
>> Hello,
>> 
>> every time I boot my dell notebook (with Wi-Fi 6 AX200), I get the error message 
>> "iwlwifi 0000:6f:00.0: BIOS contains WGDS but no WRDS".
>> 
>> This is the only message which such a high log level I get while booting,
>> it is the only message which is displayed on all text consoles on boot,
>> and it is the only message which makes my automated logchecker nervous each time.
>> 
>> However, iwlwifi works perfectly fine for wifi in spite of the message
>> (and bluetooth has deliberately been disabled in the bios settings
>> for security reasons),
>> and there is absolutely nothing I could do about the message
>> (I have no influence what dell does in their bios and what they don't).
>> Internet wisdom also says that the message is just annoying and
>> can be safely ignored.
>> 
>> Hence, the message is not an error at all ("error" being defined as
>> "something definitely failed, manual intervention required for correct operation").
>> It does not even qualify as a warning ("warning" being defined as
>> "something is likely to fail, manual checking recommended").
>> 
>> So please set the log level of that message down to "info"
>> (besides, the message text is completely cryptic and uninformative,
>> I still don't know what this message wants to tell me,
>> although I searched the internet).
>
> Discussed this with Mario.Limonciello@dell.com.
> He also wants this to be patched:
>
> On 29/10/2019 22:43, Mario.Limonciello@dell.com wrote:
>> Dell Customer Communication - Confidential
>> 
>>> -----Original Message-----
>>> From: Klaus Kusche <klaus.kusche@computerix.info>
>>>...
>>> When booting, there is a single kernel message of loglevel error
>>> which stands out in red in journalctl
>>> and which gets displayed on all text consoles (very annoying):
>>>
>>> kernel: iwlwifi 0000:6f:00.0: BIOS contains WGDS but no WRDS
>> 
>> If possible, you should probably submit a patch to iwlwifi driver to downgrade this message to
>> debug.  It really isn't useful to many people typically.
>
> So here comes a patch:
>
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c       2019-10-19 09:21:14.541422680 +0200
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c       2019-10-27 14:43:43.990623338 +0100
> @@ -1345,7 +1345,7 @@
>                  * available, issue an error, because we can't use SAR
>                  * Geo without basic SAR.
>                  */
> -               IWL_ERR(mvm, "BIOS contains WGDS but no WRDS\n");
> +               IWL_INFO(mvm, "BIOS contains WGDS but no WRDS\n");

There are so many things missing here. Please read the instructions how
to submit a patch from the link in my signature below and resend.
Klaus Kusche Oct. 31, 2019, 3:03 p.m. UTC | #2
On 31/10/2019 14:00, Kalle Valo wrote:
> Klaus Kusche <klaus.kusche@computerix.info> writes:
> 
>> Hello again,
>>
>> On 22/10/2019 20:39, Klaus Kusche wrote:
>>> Hello,
>>>
>>> every time I boot my dell notebook (with Wi-Fi 6 AX200), I get the error message 
>>> "iwlwifi 0000:6f:00.0: BIOS contains WGDS but no WRDS".
>>>
>>> This is the only message which such a high log level I get while booting,
>>> it is the only message which is displayed on all text consoles on boot,
>>> and it is the only message which makes my automated logchecker nervous each time.
>>>
>>> However, iwlwifi works perfectly fine for wifi in spite of the message
>>> (and bluetooth has deliberately been disabled in the bios settings
>>> for security reasons),
>>> and there is absolutely nothing I could do about the message
>>> (I have no influence what dell does in their bios and what they don't).
>>> Internet wisdom also says that the message is just annoying and
>>> can be safely ignored.
>>>
>>> Hence, the message is not an error at all ("error" being defined as
>>> "something definitely failed, manual intervention required for correct operation").
>>> It does not even qualify as a warning ("warning" being defined as
>>> "something is likely to fail, manual checking recommended").
>>>
>>> So please set the log level of that message down to "info"
>>> (besides, the message text is completely cryptic and uninformative,
>>> I still don't know what this message wants to tell me,
>>> although I searched the internet).
>>
>> Discussed this with Mario.Limonciello@dell.com.
>> He also wants this to be patched:
>>
>> On 29/10/2019 22:43, Mario.Limonciello@dell.com wrote:
>>> Dell Customer Communication - Confidential
>>>
>>>> -----Original Message-----
>>>> From: Klaus Kusche <klaus.kusche@computerix.info>
>>>> ...
>>>> When booting, there is a single kernel message of loglevel error
>>>> which stands out in red in journalctl
>>>> and which gets displayed on all text consoles (very annoying):
>>>>
>>>> kernel: iwlwifi 0000:6f:00.0: BIOS contains WGDS but no WRDS
>>>
>>> If possible, you should probably submit a patch to iwlwifi driver to downgrade this message to
>>> debug.  It really isn't useful to many people typically.
>>
>> So here comes a patch:
>>
>> --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c       2019-10-19 09:21:14.541422680 +0200
>> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c       2019-10-27 14:43:43.990623338 +0100
>> @@ -1345,7 +1345,7 @@
>>                  * available, issue an error, because we can't use SAR
>>                  * Geo without basic SAR.
>>                  */
>> -               IWL_ERR(mvm, "BIOS contains WGDS but no WRDS\n");
>> +               IWL_INFO(mvm, "BIOS contains WGDS but no WRDS\n");
> 
> There are so many things missing here. Please read the instructions how
> to submit a patch from the link in my signature below and resend.
> 

???

I'm not a kernel developer, I'm a plain linux user.

No git here at all (not even installed), 
hence no git-related things in the patch mail, 
and no changelog format or commit message.
The patch was manually created with diff against the sources 
of the production kernel running on my system (gentoo 5.3.7).

And how or where could I include a signed-off line 
if i can't provide a patch in changelog format?

If that helps:
I hereby certify that I wrote that patch and I'm allowd to publish it.
Feel free to include that patch in linux, modify it or whatever
with or without mentioning my name.

Patch
diff mbox series

--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c       2019-10-19 09:21:14.541422680 +0200
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c       2019-10-27 14:43:43.990623338 +0100
@@ -1345,7 +1345,7 @@ 
                 * available, issue an error, because we can't use SAR
                 * Geo without basic SAR.
                 */
-               IWL_ERR(mvm, "BIOS contains WGDS but no WRDS\n");
+               IWL_INFO(mvm, "BIOS contains WGDS but no WRDS\n");
        }
 
        if (ret < 0)