kselftests/dmabuf-heaps: Fix compiler error in one condition
diff mbox series

Message ID 20191101020450.12948-1-ice_yangxiao@163.com
State New
Headers show
Series
  • kselftests/dmabuf-heaps: Fix compiler error in one condition
Related show

Commit Message

Xiao Yang Nov. 1, 2019, 2:04 a.m. UTC
Compiling dmabuf-heaps cannot locate headers and then gets the following
error when kernel source code instead of system provides headers:
-------------------------------------------
dmabuf-heap.c:16:10: fatal error: drm/drm.h: No such file or directory
-------------------------------------------

Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
---
 tools/testing/selftests/dmabuf-heaps/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xiao Yang Nov. 1, 2019, 2:25 a.m. UTC | #1
Hi,

If you fix the issue, kindly add following tag
Reported-by: kernel test robot <lkp@intel.com>

On 11/1/19 10:04 AM, Xiao Yang wrote:
> Compiling dmabuf-heaps cannot locate headers and then gets the following
> error when kernel source code instead of system provides headers:
> -------------------------------------------
> dmabuf-heap.c:16:10: fatal error: drm/drm.h: No such file or directory
> -------------------------------------------
>
> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
> ---
>   tools/testing/selftests/dmabuf-heaps/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/dmabuf-heaps/Makefile b/tools/testing/selftests/dmabuf-heaps/Makefile
> index 8c4c36e2972d..9043e0b5a432 100644
> --- a/tools/testing/selftests/dmabuf-heaps/Makefile
> +++ b/tools/testing/selftests/dmabuf-heaps/Makefile
> @@ -1,5 +1,5 @@
>   # SPDX-License-Identifier: GPL-2.0
> -CFLAGS += -static -O3 -Wl,-no-as-needed -Wall
> +CFLAGS += -static -O3 -Wl,-no-as-needed -Wall -I../../../../usr/include
>   #LDLIBS += -lrt -lpthread -lm
>   
>   # these are all "safe" tests that don't modify
shuah Nov. 7, 2019, 8:37 p.m. UTC | #2
On 10/31/19 8:25 PM, Xiao Yang wrote:
> Hi,
> 
> If you fix the issue, kindly add following tag
> Reported-by: kernel test robot <lkp@intel.com>
> 
Do you plan to send another patch? I don't understand
if this meant you think this patch doesn't fix the
problem?

> On 11/1/19 10:04 AM, Xiao Yang wrote:
>> Compiling dmabuf-heaps cannot locate headers and then gets the following
>> error when kernel source code instead of system provides headers:
>> -------------------------------------------
>> dmabuf-heap.c:16:10: fatal error: drm/drm.h: No such file or directory
>> -------------------------------------------
>>
>> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
>> ---
>>   tools/testing/selftests/dmabuf-heaps/Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/dmabuf-heaps/Makefile 
>> b/tools/testing/selftests/dmabuf-heaps/Makefile
>> index 8c4c36e2972d..9043e0b5a432 100644
>> --- a/tools/testing/selftests/dmabuf-heaps/Makefile
>> +++ b/tools/testing/selftests/dmabuf-heaps/Makefile
>> @@ -1,5 +1,5 @@
>>   # SPDX-License-Identifier: GPL-2.0
>> -CFLAGS += -static -O3 -Wl,-no-as-needed -Wall
>> +CFLAGS += -static -O3 -Wl,-no-as-needed -Wall -I../../../../usr/include
>>   #LDLIBS += -lrt -lpthread -lm
>>   # these are all "safe" tests that don't modify
> 
> 

thanks,
-- Shuah
John Stultz Nov. 7, 2019, 8:39 p.m. UTC | #3
On Thu, Nov 7, 2019 at 12:37 PM shuah <shuah@kernel.org> wrote:
>
> On 10/31/19 8:25 PM, Xiao Yang wrote:
> > Hi,
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> Do you plan to send another patch? I don't understand
> if this meant you think this patch doesn't fix the
> problem?

I've actually folded in the fix into my patches.

thanks
-john
shuah Nov. 7, 2019, 9:10 p.m. UTC | #4
On 11/7/19 1:39 PM, John Stultz wrote:
> On Thu, Nov 7, 2019 at 12:37 PM shuah <shuah@kernel.org> wrote:
>>
>> On 10/31/19 8:25 PM, Xiao Yang wrote:
>>> Hi,
>>>
>>> If you fix the issue, kindly add following tag
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>> Do you plan to send another patch? I don't understand
>> if this meant you think this patch doesn't fix the
>> problem?
> 
> I've actually folded in the fix into my patches.
> 
> thanks
> -john
> 

Thanks for the clarification.

-- Shuah

Patch
diff mbox series

diff --git a/tools/testing/selftests/dmabuf-heaps/Makefile b/tools/testing/selftests/dmabuf-heaps/Makefile
index 8c4c36e2972d..9043e0b5a432 100644
--- a/tools/testing/selftests/dmabuf-heaps/Makefile
+++ b/tools/testing/selftests/dmabuf-heaps/Makefile
@@ -1,5 +1,5 @@ 
 # SPDX-License-Identifier: GPL-2.0
-CFLAGS += -static -O3 -Wl,-no-as-needed -Wall
+CFLAGS += -static -O3 -Wl,-no-as-needed -Wall -I../../../../usr/include
 #LDLIBS += -lrt -lpthread -lm
 
 # these are all "safe" tests that don't modify