[2/2] generic/235: Fix false failure on ext2
diff mbox series

Message ID 20191101110046.24994-3-jack@suse.cz
State New
Headers show
Series
  • Two fixups for quota tests
Related show

Commit Message

Jan Kara Nov. 1, 2019, 11 a.m. UTC
The test gives false failure on ext2 filesystem as 64k file already has
indirect block and so space usage does not exactly match expectation.
The test really needs to verify only whether quota accounting got
reenabled so just test using creating another empty file which is not
prone to these problems.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 tests/generic/235     | 5 +++--
 tests/generic/235.out | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

Patch
diff mbox series

diff --git a/tests/generic/235 b/tests/generic/235
index 6adc803c04b7..01db4711a0ec 100755
--- a/tests/generic/235
+++ b/tests/generic/235
@@ -55,8 +55,9 @@  _try_scratch_mount "-o remount,ro" 2>&1 | tee -a $seqres.full | _filter_scratch
 touch $SCRATCH_MNT/failed 2>&1 | tee -a $seqres.full | _filter_scratch
 _try_scratch_mount "-o remount,rw" 2>&1 | tee -a $seqres.full | _filter_scratch
 
-$XFS_IO_PROG -c 'pwrite 0 64k' -c 'fsync' \
-			$SCRATCH_MNT/testfile >>$seqres.full 2>&1
+touch $SCRATCH_MNT/testfile2
+chown $qa_user:$qa_user $SCRATCH_MNT/testfile2
+
 do_repquota
 
 _scratch_unmount 2>/dev/null
diff --git a/tests/generic/235.out b/tests/generic/235.out
index abcb47a69d06..87b16e0acf6d 100644
--- a/tests/generic/235.out
+++ b/tests/generic/235.out
@@ -17,10 +17,10 @@  Block grace time: 7days; Inode grace time: 7days
                         Block limits                File limits
 User            used    soft    hard  grace    used  soft  hard  grace
 ----------------------------------------------------------------------
-fsgqa     --      64       0       0              1     0     0       
+fsgqa     --       0       0       0              2     0     0       
 *** Report for group quotas on device SCRATCH_DEV
 Block grace time: 7days; Inode grace time: 7days
                         Block limits                File limits
 Group           used    soft    hard  grace    used  soft  hard  grace
 ----------------------------------------------------------------------
-fsgqa     --      64       0       0              1     0     0       
+fsgqa     --       0       0       0              2     0     0