| Message ID | 20191101142123.18136-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [i-g-t] i915/i915_selftests: Expose 'perf' selftests | expand |
On 01/11/2019 16:21, Chris Wilson wrote: > Find all the perf* selftests and expose them in our igt. In CI we expect > these not to be run in BAT (since they are just performance tests rather > than conformance), but expect the results to be available from the > shards. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > --- > tests/i915/i915_selftest.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/i915/i915_selftest.c b/tests/i915/i915_selftest.c > index 6d597e682..abc8c9c79 100644 > --- a/tests/i915/i915_selftest.c > +++ b/tests/i915/i915_selftest.c > @@ -40,4 +40,9 @@ igt_main > "live_selftests=-1 disable_display=1 st_filter=%s", > env) < sizeof(opts)); > igt_kselftests("i915", opts, "live_selftests", "live"); > + > + igt_assert(snprintf(opts, sizeof(opts), > + "perf_selftests=-1 disable_display=1 st_filter=%s", > + env) < sizeof(opts)); > + igt_kselftests("i915", opts, "perf_selftests", "perf"); > }
Quoting Lionel Landwerlin (2019-11-01 17:26:17) > On 01/11/2019 16:21, Chris Wilson wrote: > > Find all the perf* selftests and expose them in our igt. In CI we expect > > these not to be run in BAT (since they are just performance tests rather > > than conformance), but expect the results to be available from the > > shards. > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Matthew Auld <matthew.auld@intel.com> > > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> > Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> In case I confused you, not i915_perf.c per se, but when putting together the selftests we had three category ideas: mock, live and perf. Now finally get around to adding the performance centric tests (such as peak throughput of the blitter) which don't offer much CI benefit, but just occasionally convey useful information which may help in chasing bugs. -Chris
diff --git a/tests/i915/i915_selftest.c b/tests/i915/i915_selftest.c index 6d597e682..abc8c9c79 100644 --- a/tests/i915/i915_selftest.c +++ b/tests/i915/i915_selftest.c @@ -40,4 +40,9 @@ igt_main "live_selftests=-1 disable_display=1 st_filter=%s", env) < sizeof(opts)); igt_kselftests("i915", opts, "live_selftests", "live"); + + igt_assert(snprintf(opts, sizeof(opts), + "perf_selftests=-1 disable_display=1 st_filter=%s", + env) < sizeof(opts)); + igt_kselftests("i915", opts, "perf_selftests", "perf"); }
Find all the perf* selftests and expose them in our igt. In CI we expect these not to be run in BAT (since they are just performance tests rather than conformance), but expect the results to be available from the shards. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> --- tests/i915/i915_selftest.c | 5 +++++ 1 file changed, 5 insertions(+)