[1/3] ASoC: SOF: topology: fix missing NULL pointer check
diff mbox series

Message ID 20191101170916.26517-2-pierre-louis.bossart@linux.intel.com
State Accepted
Commit 8cd73ce7ba6381feb9df763240dee3a6d4aff1ca
Headers show
Series
  • ASoC: SOF: Intel: improvements for S0ix support
Related show

Commit Message

Pierre-Louis Bossart Nov. 1, 2019, 5:09 p.m. UTC
From: Keyon Jie <yang.jie@linux.intel.com>

Add check to avoid possible NULL pointer dereference issue.

This issue was reported by static analysis tools, we didn't face this
issue but we can't rule it out either as a false positive.

Reported-by: Keqiao Zhang <keqiao.zhang@intel.com>
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sof/topology.c | 5 +++++
 1 file changed, 5 insertions(+)

Patch
diff mbox series

diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index e0e2ae734632..d74acb828873 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -150,6 +150,11 @@  static int sof_keyword_dapm_event(struct snd_soc_dapm_widget *w,
 
 	/* get runtime PCM params using widget's stream name */
 	spcm = snd_sof_find_spcm_name(sdev, swidget->widget->sname);
+	if (!spcm) {
+		dev_err(sdev->dev, "error: cannot find PCM for %s\n",
+			swidget->widget->name);
+		return -EINVAL;
+	}
 
 	/* process events */
 	switch (event) {