[-next] thermal: ti-soc-thermal: Remove dev_err() on platform_get_irq() failure
diff mbox series

Message ID 20191102075654.36700-1-yuehaibing@huawei.com
State New
Delegated to: Eduardo Valentin
Headers show
Series
  • [-next] thermal: ti-soc-thermal: Remove dev_err() on platform_get_irq() failure
Related show

Commit Message

YueHaibing Nov. 2, 2019, 7:56 a.m. UTC
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/thermal/ti-soc-thermal/ti-bandgap.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Keerthy Nov. 5, 2019, 6:08 a.m. UTC | #1
On 02/11/19 1:26 PM, YueHaibing wrote:
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.

Acked-by: Keerthy <j-keerthy@ti.com>

> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   drivers/thermal/ti-soc-thermal/ti-bandgap.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> index 2fa78f7..89c3ba7 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> @@ -787,10 +787,9 @@ static int ti_bandgap_talert_init(struct ti_bandgap *bgp,
>   	int ret;
>   
>   	bgp->irq = platform_get_irq(pdev, 0);
> -	if (bgp->irq < 0) {
> -		dev_err(&pdev->dev, "get_irq failed\n");
> +	if (bgp->irq < 0)
>   		return bgp->irq;
> -	}
> +
>   	ret = request_threaded_irq(bgp->irq, NULL,
>   				   ti_bandgap_talert_irq_handler,
>   				   IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
>

Patch
diff mbox series

diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
index 2fa78f7..89c3ba7 100644
--- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
+++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
@@ -787,10 +787,9 @@  static int ti_bandgap_talert_init(struct ti_bandgap *bgp,
 	int ret;
 
 	bgp->irq = platform_get_irq(pdev, 0);
-	if (bgp->irq < 0) {
-		dev_err(&pdev->dev, "get_irq failed\n");
+	if (bgp->irq < 0)
 		return bgp->irq;
-	}
+
 	ret = request_threaded_irq(bgp->irq, NULL,
 				   ti_bandgap_talert_irq_handler,
 				   IRQF_TRIGGER_HIGH | IRQF_ONESHOT,