clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk
diff mbox series

Message ID 1572855483-10624-1-git-send-email-peng.fan@nxp.com
State New
Headers show
Series
  • clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk
Related show

Commit Message

Peng Fan Nov. 4, 2019, 8:19 a.m. UTC
From: Peng Fan <peng.fan@nxp.com>

It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
without ipg clk. Actually there are ipg clks for other sai clks,
let's add IMX8MN_CLK_SAI7_IPG clk.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clk/imx/clk-imx8mn.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Peng Fan Nov. 4, 2019, 8:21 a.m. UTC | #1
> Subject: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk

Missed to add, patch was made based on clk_hw API patch
https://patchwork.kernel.org/patch/11224941/

Thanks,
Peng.
> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
> without ipg clk. Actually there are ipg clks for other sai clks, let's add
> IMX8MN_CLK_SAI7_IPG clk.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/clk/imx/clk-imx8mn.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 838f6e2347f1..5e801892c631 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct
> platform_device *pdev)
>  	clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk",
> "ipg_audio_root", base + 0x43b0, 0);
>  	clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk",
> "ipg_audio_root", base + 0x45f0, 0);
>  	clks[IMX8MN_CLK_SAI7_ROOT] =
> imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0,
> &share_count_sai7);
> +	clks[IMX8MN_CLK_SAI7_IPG] =
> imx_clk_hw_gate2_shared2("sai7_ipg_clk",
> +"ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
> 
>  	clks[IMX8MN_CLK_DRAM_ALT_ROOT] =
> imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
> 
> --
> 2.16.4
Abel Vesa Nov. 5, 2019, 11:36 a.m. UTC | #2
On 19-11-04 08:19:33, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
> without ipg clk. Actually there are ipg clks for other sai clks,
> let's add IMX8MN_CLK_SAI7_IPG clk.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

> ---
>  drivers/clk/imx/clk-imx8mn.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 838f6e2347f1..5e801892c631 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
>  	clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk", "ipg_audio_root", base + 0x43b0, 0);
>  	clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk", "ipg_audio_root", base + 0x45f0, 0);
>  	clks[IMX8MN_CLK_SAI7_ROOT] = imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0, &share_count_sai7);
> +	clks[IMX8MN_CLK_SAI7_IPG] = imx_clk_hw_gate2_shared2("sai7_ipg_clk", "ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
>  
>  	clks[IMX8MN_CLK_DRAM_ALT_ROOT] = imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
>  
> -- 
> 2.16.4
>

Patch
diff mbox series

diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index 838f6e2347f1..5e801892c631 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -556,6 +556,7 @@  static int imx8mn_clocks_probe(struct platform_device *pdev)
 	clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk", "ipg_audio_root", base + 0x43b0, 0);
 	clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk", "ipg_audio_root", base + 0x45f0, 0);
 	clks[IMX8MN_CLK_SAI7_ROOT] = imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0, &share_count_sai7);
+	clks[IMX8MN_CLK_SAI7_IPG] = imx_clk_hw_gate2_shared2("sai7_ipg_clk", "ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
 
 	clks[IMX8MN_CLK_DRAM_ALT_ROOT] = imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);