[v2,3/5] ARM: dts: dra7: add vpe clkctrl node
diff mbox series

Message ID 20191104203841.3628-4-bparrot@ti.com
State New
Headers show
Series
  • ARM: dts: dra7: add vpe nodes
Related show

Commit Message

Benoit Parrot Nov. 4, 2019, 8:38 p.m. UTC
Add clkctrl nodes for VPE module.

Signed-off-by: Benoit Parrot <bparrot@ti.com>
---
 arch/arm/boot/dts/dra7xx-clocks.dtsi | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

Comments

Tony Lindgren Nov. 8, 2019, 4:55 p.m. UTC | #1
Hi,

* Benoit Parrot <bparrot@ti.com> [191104 20:39]:
> Add clkctrl nodes for VPE module.

Can you please add a comment describing that we currently need to
use custom node names here instead of the standard naming?

I can queue this and other dts change once I have an immutable clock
changes branch from Tero.

Or if Tero wants to also pick up the clock node dtsi patch I can ack it,
up to Tero.

Regards,

Tony


> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> ---
>  arch/arm/boot/dts/dra7xx-clocks.dtsi | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> index 93e1eb83bed9..d1c2406ec71c 100644
> --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> @@ -1591,10 +1591,10 @@
>  
>  	rtc_cm: rtc-cm@700 {
>  		compatible = "ti,omap4-cm";
> -		reg = <0x700 0x100>;
> +		reg = <0x700 0x60>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> -		ranges = <0 0x700 0x100>;
> +		ranges = <0 0x700 0x60>;
>  
>  		rtc_clkctrl: rtc-clkctrl@20 {
>  			compatible = "ti,clkctrl";
> @@ -1603,6 +1603,20 @@
>  		};
>  	};
>  
> +	vpe_cm: vpe-cm@760 {
> +		compatible = "ti,omap4-cm";
> +		reg = <0x760 0xc>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0 0x760 0xc>;
> +
> +		vpe_clkctrl: vpe-clkctrl@0 {
> +			compatible = "ti,clkctrl";
> +			reg = <0x0 0xc>;
> +			#clock-cells = <2>;
> +		};
> +	};
> +
>  };
>  
>  &cm_core {
> -- 
> 2.17.1
>
Benoit Parrot Nov. 8, 2019, 5:02 p.m. UTC | #2
Tony Lindgren <tony@atomide.com> wrote on Fri [2019-Nov-08 08:55:54 -0800]:
> Hi,
> 
> * Benoit Parrot <bparrot@ti.com> [191104 20:39]:
> > Add clkctrl nodes for VPE module.
> 
> Can you please add a comment describing that we currently need to
> use custom node names here instead of the standard naming?

Tony, what do you mean "custom node name" here?
I followed the exact same syntax that was already there... confused..

Benoit

> 
> I can queue this and other dts change once I have an immutable clock
> changes branch from Tero.
> 
> Or if Tero wants to also pick up the clock node dtsi patch I can ack it,
> up to Tero.
> 
> Regards,
> 
> Tony
> 
> 
> > Signed-off-by: Benoit Parrot <bparrot@ti.com>
> > ---
> >  arch/arm/boot/dts/dra7xx-clocks.dtsi | 18 ++++++++++++++++--
> >  1 file changed, 16 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> > index 93e1eb83bed9..d1c2406ec71c 100644
> > --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
> > +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> > @@ -1591,10 +1591,10 @@
> >  
> >  	rtc_cm: rtc-cm@700 {
> >  		compatible = "ti,omap4-cm";
> > -		reg = <0x700 0x100>;
> > +		reg = <0x700 0x60>;
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> > -		ranges = <0 0x700 0x100>;
> > +		ranges = <0 0x700 0x60>;
> >  
> >  		rtc_clkctrl: rtc-clkctrl@20 {
> >  			compatible = "ti,clkctrl";
> > @@ -1603,6 +1603,20 @@
> >  		};
> >  	};
> >  
> > +	vpe_cm: vpe-cm@760 {
> > +		compatible = "ti,omap4-cm";
> > +		reg = <0x760 0xc>;
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0 0x760 0xc>;
> > +
> > +		vpe_clkctrl: vpe-clkctrl@0 {
> > +			compatible = "ti,clkctrl";
> > +			reg = <0x0 0xc>;
> > +			#clock-cells = <2>;
> > +		};
> > +	};
> > +
> >  };
> >  
> >  &cm_core {
> > -- 
> > 2.17.1
> >
Tony Lindgren Nov. 8, 2019, 5:06 p.m. UTC | #3
* Benoit Parrot <bparrot@ti.com> [191108 17:00]:
> Tony Lindgren <tony@atomide.com> wrote on Fri [2019-Nov-08 08:55:54 -0800]:
> > Hi,
> > 
> > * Benoit Parrot <bparrot@ti.com> [191104 20:39]:
> > > Add clkctrl nodes for VPE module.
> > 
> > Can you please add a comment describing that we currently need to
> > use custom node names here instead of the standard naming?
> 
> Tony, what do you mean "custom node name" here?
> I followed the exact same syntax that was already there... confused..

Oh sorry for being unclear. Yeah so the conclusion of the discussion was
that we still need custom node names for now.

And for patch "[PATCH] clk: ti: add clkctrl data dra7 sgx" I added you to
Cc, and it has this in the patch description:

"Note that because of the current dts node name dependency for mapping to
 clock domain, we must still use "gpu-clkctrl@" naming instead of generic
 "clock@" naming for the node. And because of this, it's probably best to
 apply the dts node addition together along with the other clock changes."

So can you please add something similar to your clock node patches too
to explain why we cannot use standard node names there?

Regards,

Tony

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
index 93e1eb83bed9..d1c2406ec71c 100644
--- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
+++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
@@ -1591,10 +1591,10 @@ 
 
 	rtc_cm: rtc-cm@700 {
 		compatible = "ti,omap4-cm";
-		reg = <0x700 0x100>;
+		reg = <0x700 0x60>;
 		#address-cells = <1>;
 		#size-cells = <1>;
-		ranges = <0 0x700 0x100>;
+		ranges = <0 0x700 0x60>;
 
 		rtc_clkctrl: rtc-clkctrl@20 {
 			compatible = "ti,clkctrl";
@@ -1603,6 +1603,20 @@ 
 		};
 	};
 
+	vpe_cm: vpe-cm@760 {
+		compatible = "ti,omap4-cm";
+		reg = <0x760 0xc>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0 0x760 0xc>;
+
+		vpe_clkctrl: vpe-clkctrl@0 {
+			compatible = "ti,clkctrl";
+			reg = <0x0 0xc>;
+			#clock-cells = <2>;
+		};
+	};
+
 };
 
 &cm_core {