[PULL,00/13] Linux user for 4.2 patches
mbox

Message ID 20191105181119.26779-1-laurent@vivier.eu
State New
Headers show

Pull-request

git://github.com/vivier/qemu.git tags/linux-user-for-4.2-pull-request

Message

Laurent Vivier Nov. 5, 2019, 6:11 p.m. UTC
The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408:

  Merge remote-tracking branch 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 17:59:03 +0000)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/linux-user-for-4.2-pull-request

for you to fetch changes up to bbba2b13799d3220f1f1d84bbaed3f916215fca5:

  linux-user/alpha: Set r20 secondary return value (2019-11-05 10:53:55 +0100)

----------------------------------------------------------------
sparc/sparc64 fixes: this doesn't fix debian chroot for me
but they are a step in the good direction.
Fix Netlink support.
Trivial fix for alpha

----------------------------------------------------------------

Josh Kunz (1):
  linux-user: Support for NETLINK socket options

Richard Henderson (12):
  scripts/qemu-binfmt-conf: Update for sparc64
  tests/tcg/multiarch/linux-test: Fix error check for shmat
  target/sparc: Define an enumeration for accessing env->regwptr
  linux-user/sparc: Use WREG constants in sparc/target_cpu.h
  linux-user/sparc: Begin using WREG constants in sparc/signal.c
  linux-user/sparc: Use WREG_SP constant in sparc/signal.c
  linux-user/sparc: Fix WREG usage in setup_frame
  linux-user/sparc64: Fix target_signal_frame
  linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
  linux-user: Introduce cpu_clone_regs_parent
  linux-user/sparc: Fix cpu_clone_regs_*
  linux-user/alpha: Set r20 secondary return value

 linux-user/aarch64/target_cpu.h    |   7 +-
 linux-user/alpha/target_cpu.h      |  16 ++++-
 linux-user/arm/target_cpu.h        |   7 +-
 linux-user/cris/target_cpu.h       |   7 +-
 linux-user/hppa/target_cpu.h       |   7 +-
 linux-user/i386/target_cpu.h       |   7 +-
 linux-user/m68k/target_cpu.h       |   7 +-
 linux-user/microblaze/target_cpu.h |   7 +-
 linux-user/mips/target_cpu.h       |   7 +-
 linux-user/nios2/target_cpu.h      |   7 +-
 linux-user/openrisc/target_cpu.h   |   8 ++-
 linux-user/ppc/target_cpu.h        |   7 +-
 linux-user/riscv/target_cpu.h      |   7 +-
 linux-user/s390x/target_cpu.h      |   7 +-
 linux-user/sh4/target_cpu.h        |   7 +-
 linux-user/sparc/signal.c          | 102 ++++++++++-----------------
 linux-user/sparc/target_cpu.h      |  60 +++++++++++-----
 linux-user/syscall.c               | 107 ++++++++++++++++++++++++++++-
 linux-user/tilegx/target_cpu.h     |   7 +-
 linux-user/xtensa/target_cpu.h     |   8 ++-
 scripts/qemu-binfmt-conf.sh        |   8 ++-
 target/sparc/cpu.h                 |  33 +++++++++
 tests/tcg/multiarch/linux-test.c   |   3 +-
 23 files changed, 338 insertions(+), 105 deletions(-)

Comments

no-reply@patchew.org Nov. 5, 2019, 10:06 p.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20191105181119.26779-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/13] Linux user for 4.2 patches
Type: series
Message-id: 20191105181119.26779-1-laurent@vivier.eu

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   36609b4..412fbef  master     -> master
Switched to a new branch 'test'
965f842 linux-user/alpha: Set r20 secondary return value
a59ca3b linux-user/sparc: Fix cpu_clone_regs_*
046ba0d linux-user: Introduce cpu_clone_regs_parent
1afe1bc linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
748db1e linux-user/sparc64: Fix target_signal_frame
2e90cc8 linux-user/sparc: Fix WREG usage in setup_frame
608f997 linux-user/sparc: Use WREG_SP constant in sparc/signal.c
279530b linux-user/sparc: Begin using WREG constants in sparc/signal.c
3d27837 linux-user/sparc: Use WREG constants in sparc/target_cpu.h
b30437c target/sparc: Define an enumeration for accessing env->regwptr
128b52d tests/tcg/multiarch/linux-test: Fix error check for shmat
e78b5ec scripts/qemu-binfmt-conf: Update for sparc64
5a6b0f4 linux-user: Support for NETLINK socket options

=== OUTPUT BEGIN ===
1/13 Checking commit 5a6b0f46c670 (linux-user: Support for NETLINK socket options)
2/13 Checking commit e78b5ec2867e (scripts/qemu-binfmt-conf: Update for sparc64)
WARNING: line over 80 characters
#36: FILE: scripts/qemu-binfmt-conf.sh:41:
+sparc64_magic='\x7fELF\x02\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x2b'

ERROR: line over 90 characters
#37: FILE: scripts/qemu-binfmt-conf.sh:42:
+sparc64_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

total: 1 errors, 1 warnings, 20 lines checked

Patch 2/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/13 Checking commit 128b52d81645 (tests/tcg/multiarch/linux-test: Fix error check for shmat)
4/13 Checking commit b30437c1b51f (target/sparc: Define an enumeration for accessing env->regwptr)
5/13 Checking commit 3d27837139f0 (linux-user/sparc: Use WREG constants in sparc/target_cpu.h)
6/13 Checking commit 279530b9caeb (linux-user/sparc: Begin using WREG constants in sparc/signal.c)
ERROR: spaces required around that '+' (ctx:VxV)
#52: FILE: linux-user/sparc/signal.c:151:
+        __put_user(env->regwptr[WREG_O0 + i], &si->si_regs.u_regs[i+8]);
                                                                    ^

ERROR: spaces required around that '+' (ctx:VxV)
#124: FILE: linux-user/sparc/signal.c:290:
+        __get_user(env->regwptr[i + WREG_O0], &sf->info.si_regs.u_regs[i+8]);
                                                                         ^

ERROR: spaces required around that '+' (ctx:VxV)
#171: FILE: linux-user/sparc/signal.c:460:
+    w_addr = TARGET_STACK_BIAS+env->regwptr[WREG_O6];
                               ^

ERROR: spaces required around that '+' (ctx:VxV)
#206: FILE: linux-user/sparc/signal.c:563:
+    w_addr = TARGET_STACK_BIAS+env->regwptr[WREG_O6];
                               ^

total: 4 errors, 0 warnings, 175 lines checked

Patch 6/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/13 Checking commit 608f99725ea6 (linux-user/sparc: Use WREG_SP constant in sparc/signal.c)
8/13 Checking commit 2e90cc889f5a (linux-user/sparc: Fix WREG usage in setup_frame)
9/13 Checking commit 748db1e8856b (linux-user/sparc64: Fix target_signal_frame)
ERROR: space prohibited between function name and open parenthesis '('
#24: FILE: linux-user/sparc/signal.c:90:
+    uint32_t            insns[2] __attribute__ ((aligned (8)));

total: 1 errors, 0 warnings, 16 lines checked

Patch 9/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/13 Checking commit 1afe1bce0919 (linux-user: Rename cpu_clone_regs to cpu_clone_regs_child)
11/13 Checking commit 046ba0d62866 (linux-user: Introduce cpu_clone_regs_parent)
12/13 Checking commit a59ca3b85381 (linux-user/sparc: Fix cpu_clone_regs_*)
13/13 Checking commit 965f842f57f6 (linux-user/alpha: Set r20 secondary return value)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191105181119.26779-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Laurent Vivier Nov. 5, 2019, 10:14 p.m. UTC | #2
Richard,

could you update your series?

If you prefer to wait next release I can drop your series from the pull
request.

Thanks,
Laurent

Le 05/11/2019 à 23:06, no-reply@patchew.org a écrit :
> Patchew URL: https://patchew.org/QEMU/20191105181119.26779-1-laurent@vivier.eu/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [PULL 00/13] Linux user for 4.2 patches
> Type: series
> Message-id: 20191105181119.26779-1-laurent@vivier.eu
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>    36609b4..412fbef  master     -> master
> Switched to a new branch 'test'
> 965f842 linux-user/alpha: Set r20 secondary return value
> a59ca3b linux-user/sparc: Fix cpu_clone_regs_*
> 046ba0d linux-user: Introduce cpu_clone_regs_parent
> 1afe1bc linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
> 748db1e linux-user/sparc64: Fix target_signal_frame
> 2e90cc8 linux-user/sparc: Fix WREG usage in setup_frame
> 608f997 linux-user/sparc: Use WREG_SP constant in sparc/signal.c
> 279530b linux-user/sparc: Begin using WREG constants in sparc/signal.c
> 3d27837 linux-user/sparc: Use WREG constants in sparc/target_cpu.h
> b30437c target/sparc: Define an enumeration for accessing env->regwptr
> 128b52d tests/tcg/multiarch/linux-test: Fix error check for shmat
> e78b5ec scripts/qemu-binfmt-conf: Update for sparc64
> 5a6b0f4 linux-user: Support for NETLINK socket options
> 
> === OUTPUT BEGIN ===
> 1/13 Checking commit 5a6b0f46c670 (linux-user: Support for NETLINK socket options)
> 2/13 Checking commit e78b5ec2867e (scripts/qemu-binfmt-conf: Update for sparc64)
> WARNING: line over 80 characters
> #36: FILE: scripts/qemu-binfmt-conf.sh:41:
> +sparc64_magic='\x7fELF\x02\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x2b'
> 
> ERROR: line over 90 characters
> #37: FILE: scripts/qemu-binfmt-conf.sh:42:
> +sparc64_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'
> 
> total: 1 errors, 1 warnings, 20 lines checked
> 
> Patch 2/13 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 3/13 Checking commit 128b52d81645 (tests/tcg/multiarch/linux-test: Fix error check for shmat)
> 4/13 Checking commit b30437c1b51f (target/sparc: Define an enumeration for accessing env->regwptr)
> 5/13 Checking commit 3d27837139f0 (linux-user/sparc: Use WREG constants in sparc/target_cpu.h)
> 6/13 Checking commit 279530b9caeb (linux-user/sparc: Begin using WREG constants in sparc/signal.c)
> ERROR: spaces required around that '+' (ctx:VxV)
> #52: FILE: linux-user/sparc/signal.c:151:
> +        __put_user(env->regwptr[WREG_O0 + i], &si->si_regs.u_regs[i+8]);
>                                                                     ^
> 
> ERROR: spaces required around that '+' (ctx:VxV)
> #124: FILE: linux-user/sparc/signal.c:290:
> +        __get_user(env->regwptr[i + WREG_O0], &sf->info.si_regs.u_regs[i+8]);
>                                                                          ^
> 
> ERROR: spaces required around that '+' (ctx:VxV)
> #171: FILE: linux-user/sparc/signal.c:460:
> +    w_addr = TARGET_STACK_BIAS+env->regwptr[WREG_O6];
>                                ^
> 
> ERROR: spaces required around that '+' (ctx:VxV)
> #206: FILE: linux-user/sparc/signal.c:563:
> +    w_addr = TARGET_STACK_BIAS+env->regwptr[WREG_O6];
>                                ^
> 
> total: 4 errors, 0 warnings, 175 lines checked
> 
> Patch 6/13 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 7/13 Checking commit 608f99725ea6 (linux-user/sparc: Use WREG_SP constant in sparc/signal.c)
> 8/13 Checking commit 2e90cc889f5a (linux-user/sparc: Fix WREG usage in setup_frame)
> 9/13 Checking commit 748db1e8856b (linux-user/sparc64: Fix target_signal_frame)
> ERROR: space prohibited between function name and open parenthesis '('
> #24: FILE: linux-user/sparc/signal.c:90:
> +    uint32_t            insns[2] __attribute__ ((aligned (8)));
> 
> total: 1 errors, 0 warnings, 16 lines checked
> 
> Patch 9/13 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 10/13 Checking commit 1afe1bce0919 (linux-user: Rename cpu_clone_regs to cpu_clone_regs_child)
> 11/13 Checking commit 046ba0d62866 (linux-user: Introduce cpu_clone_regs_parent)
> 12/13 Checking commit a59ca3b85381 (linux-user/sparc: Fix cpu_clone_regs_*)
> 13/13 Checking commit 965f842f57f6 (linux-user/alpha: Set r20 secondary return value)
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/20191105181119.26779-1-laurent@vivier.eu/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
>
Philippe Mathieu-Daudé Nov. 5, 2019, 10:56 p.m. UTC | #3
On 11/5/19 11:14 PM, Laurent Vivier wrote:
> Richard,
> 
> could you update your series?
> 
> If you prefer to wait next release I can drop your series from the pull
> request.
> 
> Thanks,
> Laurent
> 
> Le 05/11/2019 à 23:06, no-reply@patchew.org a écrit :
>> Patchew URL: https://patchew.org/QEMU/20191105181119.26779-1-laurent@vivier.eu/
>>
>>
>>
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
>>
>> Subject: [PULL 00/13] Linux user for 4.2 patches
>> Type: series
>> Message-id: 20191105181119.26779-1-laurent@vivier.eu
>>
>> === TEST SCRIPT BEGIN ===
>> #!/bin/bash
>> git rev-parse base > /dev/null || exit 0
>> git config --local diff.renamelimit 0
>> git config --local diff.renames True
>> git config --local diff.algorithm histogram
>> ./scripts/checkpatch.pl --mailback base..
>> === TEST SCRIPT END ===
>>
>> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>>  From https://github.com/patchew-project/qemu
>>     36609b4..412fbef  master     -> master
>> Switched to a new branch 'test'
>> 965f842 linux-user/alpha: Set r20 secondary return value
>> a59ca3b linux-user/sparc: Fix cpu_clone_regs_*
>> 046ba0d linux-user: Introduce cpu_clone_regs_parent
>> 1afe1bc linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
>> 748db1e linux-user/sparc64: Fix target_signal_frame
>> 2e90cc8 linux-user/sparc: Fix WREG usage in setup_frame
>> 608f997 linux-user/sparc: Use WREG_SP constant in sparc/signal.c
>> 279530b linux-user/sparc: Begin using WREG constants in sparc/signal.c
>> 3d27837 linux-user/sparc: Use WREG constants in sparc/target_cpu.h
>> b30437c target/sparc: Define an enumeration for accessing env->regwptr
>> 128b52d tests/tcg/multiarch/linux-test: Fix error check for shmat
>> e78b5ec scripts/qemu-binfmt-conf: Update for sparc64
>> 5a6b0f4 linux-user: Support for NETLINK socket options
>>
>> === OUTPUT BEGIN ===
>> 1/13 Checking commit 5a6b0f46c670 (linux-user: Support for NETLINK socket options)
>> 2/13 Checking commit e78b5ec2867e (scripts/qemu-binfmt-conf: Update for sparc64)
>> WARNING: line over 80 characters
>> #36: FILE: scripts/qemu-binfmt-conf.sh:41:
>> +sparc64_magic='\x7fELF\x02\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x2b'

False positive. Shouldn't we take this file out of checkpatch default list?

>>
>> ERROR: line over 90 characters
>> #37: FILE: scripts/qemu-binfmt-conf.sh:42:
>> +sparc64_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

Ditto.

>>
>> total: 1 errors, 1 warnings, 20 lines checked
>>
>> Patch 2/13 has style problems, please review.  If any of these errors
>> are false positives report them to the maintainer, see
>> CHECKPATCH in MAINTAINERS.
>>
>> 3/13 Checking commit 128b52d81645 (tests/tcg/multiarch/linux-test: Fix error check for shmat)
>> 4/13 Checking commit b30437c1b51f (target/sparc: Define an enumeration for accessing env->regwptr)
>> 5/13 Checking commit 3d27837139f0 (linux-user/sparc: Use WREG constants in sparc/target_cpu.h)
>> 6/13 Checking commit 279530b9caeb (linux-user/sparc: Begin using WREG constants in sparc/signal.c)
>> ERROR: spaces required around that '+' (ctx:VxV)
>> #52: FILE: linux-user/sparc/signal.c:151:
>> +        __put_user(env->regwptr[WREG_O0 + i], &si->si_regs.u_regs[i+8]);
>>                                                                      ^

True positive :/

>>
>> ERROR: spaces required around that '+' (ctx:VxV)
>> #124: FILE: linux-user/sparc/signal.c:290:
>> +        __get_user(env->regwptr[i + WREG_O0], &sf->info.si_regs.u_regs[i+8]);
>>                                                                           ^

Again.

>>
>> ERROR: spaces required around that '+' (ctx:VxV)
>> #171: FILE: linux-user/sparc/signal.c:460:
>> +    w_addr = TARGET_STACK_BIAS+env->regwptr[WREG_O6];
>>                                 ^

Again.

>>
>> ERROR: spaces required around that '+' (ctx:VxV)
>> #206: FILE: linux-user/sparc/signal.c:563:
>> +    w_addr = TARGET_STACK_BIAS+env->regwptr[WREG_O6];
>>                                 ^

Again.

>>
>> total: 4 errors, 0 warnings, 175 lines checked
>>
>> Patch 6/13 has style problems, please review.  If any of these errors
>> are false positives report them to the maintainer, see
>> CHECKPATCH in MAINTAINERS.
>>
>> 7/13 Checking commit 608f99725ea6 (linux-user/sparc: Use WREG_SP constant in sparc/signal.c)
>> 8/13 Checking commit 2e90cc889f5a (linux-user/sparc: Fix WREG usage in setup_frame)
>> 9/13 Checking commit 748db1e8856b (linux-user/sparc64: Fix target_signal_frame)
>> ERROR: space prohibited between function name and open parenthesis '('
>> #24: FILE: linux-user/sparc/signal.c:90:
>> +    uint32_t            insns[2] __attribute__ ((aligned (8)));

False positive likely?

>>
>> total: 1 errors, 0 warnings, 16 lines checked
>>
>> Patch 9/13 has style problems, please review.  If any of these errors
>> are false positives report them to the maintainer, see
>> CHECKPATCH in MAINTAINERS.
>>
>> 10/13 Checking commit 1afe1bce0919 (linux-user: Rename cpu_clone_regs to cpu_clone_regs_child)
>> 11/13 Checking commit 046ba0d62866 (linux-user: Introduce cpu_clone_regs_parent)
>> 12/13 Checking commit a59ca3b85381 (linux-user/sparc: Fix cpu_clone_regs_*)
>> 13/13 Checking commit 965f842f57f6 (linux-user/alpha: Set r20 secondary return value)
>> === OUTPUT END ===
>>
>> Test command exited with code: 1
>>
>>
>> The full log is available at
>> http://patchew.org/logs/20191105181119.26779-1-laurent@vivier.eu/testing.checkpatch/?type=message.
>> ---
>> Email generated automatically by Patchew [https://patchew.org/].
>> Please send your feedback to patchew-devel@redhat.com
>>