[07/17] mm, vmstat: hide /proc/pagetypeinfo from normal users

Commit Message

Andrew Morton Nov. 6, 2019, 5:16 a.m. UTC

From: Michal Hocko <[e-mail]>
Subject: mm, vmstat: hide /proc/pagetypeinfo from normal users

/proc/pagetypeinfo is a debugging tool to examine internal page allocator
state wrt to fragmentation.  It is not very useful for any other use so
normal users really do not need to read this file.

Waiman Long has noticed that reading this file can have negative side
effects because zone->lock is necessary for gathering data and that a)
interferes with the page allocator and its users and b) can lead to hard
lockups on large machines which have very long free_list.

Reduce both issues by simply not exporting the file to regular users.

Link: http://lkml.kernel.org/r/[e-mail]
Fixes: 467c996c1e19 ("Print out statistics in relation to fragmentation avoidance to /proc/pagetypeinfo")
Signed-off-by: Michal Hocko <[e-mail]>
Reported-by: Waiman Long <[e-mail]>
Acked-by: Mel Gorman <[e-mail]>
Acked-by: Vlastimil Babka <[e-mail]>
Acked-by: Waiman Long <[e-mail]>
Acked-by: Rafael Aquini <[e-mail]>
Acked-by: David Rientjes <[e-mail]>
Reviewed-by: Andrew Morton <[e-mail]>
Cc: David Hildenbrand <[e-mail]>
Cc: Johannes Weiner <[e-mail]>
Cc: Roman Gushchin <[e-mail]>
Cc: Konstantin Khlebnikov <[e-mail]>
Cc: Jann Horn <[e-mail]>
Cc: Song Liu <[e-mail]>
Cc: Greg Kroah-Hartman <[e-mail]>
Cc: <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/vmstat.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

--- a/mm/vmstat.c~mm-vmstat-hide-proc-pagetypeinfo-from-normal-users
+++ a/mm/vmstat.c
@@ -1972,7 +1972,7 @@  void __init init_mm_internals(void)
 #endif
 #ifdef CONFIG_PROC_FS
 	proc_create_seq("buddyinfo", 0444, NULL, &fragmentation_op);
-	proc_create_seq("pagetypeinfo", 0444, NULL, &pagetypeinfo_op);
+	proc_create_seq("pagetypeinfo", 0400, NULL, &pagetypeinfo_op);
 	proc_create_seq("vmstat", 0444, NULL, &vmstat_op);
 	proc_create_seq("zoneinfo", 0444, NULL, &zoneinfo_op);
 #endif