From patchwork Wed Nov 6 06:06:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Ogorchock X-Patchwork-Id: 11229341 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BAA4115AB for ; Wed, 6 Nov 2019 06:06:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 839FD2087E for ; Wed, 6 Nov 2019 06:06:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JXtliQZ/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729937AbfKFGG7 (ORCPT ); Wed, 6 Nov 2019 01:06:59 -0500 Received: from mail-yb1-f194.google.com ([209.85.219.194]:36220 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbfKFGG7 (ORCPT ); Wed, 6 Nov 2019 01:06:59 -0500 Received: by mail-yb1-f194.google.com with SMTP id v17so3510478ybs.3 for ; Tue, 05 Nov 2019 22:06:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jX4DGcyJnk4xI70Z9AvXghk8Adm9wrlKyUJplQyV5E4=; b=JXtliQZ/px1s5eyBao1ftcnCQ4JK6zwOA3TtzsX4nKEIOPpSgcRPt2hM6ejn1qnZp2 FVxqvLbUubo7a7eUPkFkxmI6GoSTMV9IY5jWMVi56Gn3HLSejHeP2yyJPMu+UKqJdP+B R7r3641P42kHLrq9nhARQfAq4DHcSzT0csj4Mh+neqM/EoWA2GCq2qt1zUUgmlNxgXXe UzxNr0mdpM+0nh7EcBrR3GC7+CEcPfCLCpjGX7zA9vdMawCVaJogrT2E0/tIDmIt0SyM sScJY6fqI2QOL026Bqj6XrcChUCAz2321NGsKRMMo8GyTmDzoPiSOeKrZ2Cq+2eU+tnt 1NFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jX4DGcyJnk4xI70Z9AvXghk8Adm9wrlKyUJplQyV5E4=; b=JyUxbyfcnorMUODeuiJ4tVCUO1EyuGXFSRRe/aNAjLpYXKmuWRV7nbNPIWd5kzizTN CixaRDp3O4f+T20BOw5AfMiRmGUcwkzS78ph0FiO8Eox47pccbx9stylRPzbOVuvX+Zp eDFJqj9JSgExreWjfEjCM3e3c0ACrPVXmAyYIzfajH6dN8ikJts9LWmVFitd5FAiUyEP C8MGEfUlQLv8f8m1PJn4HemM24yYBQ/CUr2n5Mm3YthstzJ4WeOnESXSQnbFgzJ4W/0S 21eXa1pP6IGrnlv3iIEAEPYWi2VY1cHC1vsR+FXMvI5YDJ17+Zrkw6oEhy+QRhz8i9p2 2kxw== X-Gm-Message-State: APjAAAVBf7GaO0l/vr5/xypTw34XarUZ9Own0Y1895SrETH/8/kFLeu6 CW3BbvpkUHrS0P0R5HAQ6TcNfJXJcqUSZQ== X-Google-Smtp-Source: APXvYqz/KPngKCnHIlDK41r4sOymCM00hrBEhTO02Px566pdc1aWWc3OHWcKFvRgWE+PjIsqNDFrAA== X-Received: by 2002:a25:4202:: with SMTP id p2mr772845yba.422.1573020417492; Tue, 05 Nov 2019 22:06:57 -0800 (PST) Received: from Arrakis.djogorchock.com ([136.33.205.58]) by smtp.gmail.com with ESMTPSA id e82sm11039596ywb.87.2019.11.05.22.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 22:06:56 -0800 (PST) From: "Daniel J. Ogorchock" To: linux-input@vger.kernel.org Cc: thunderbird2k@gmail.com, blaws05@gmail.com, benjamin.tissoires@redhat.com, jikos@kernel.org, Roderick.Colenbrander@sony.com, svv@google.com, s.jegen@gmail.com, "Daniel J. Ogorchock" Subject: [PATCH v9 02/10] HID: nintendo: add player led support Date: Wed, 6 Nov 2019 00:06:40 -0600 Message-Id: <20191106060648.3018478-3-djogorchock@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191106060648.3018478-1-djogorchock@gmail.com> References: <20191106060648.3018478-1-djogorchock@gmail.com> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org This patch adds led_classdev functionality to the switch controller driver. It adds support for the 4 player LEDs. The Home Button LED still needs to be supported on the pro controllers and right joy-con. Signed-off-by: Daniel J. Ogorchock --- drivers/hid/Kconfig | 2 + drivers/hid/hid-nintendo.c | 95 +++++++++++++++++++++++++++++++++++++- 2 files changed, 95 insertions(+), 2 deletions(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 47ec750c2baf..41f7da50896f 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -695,6 +695,8 @@ config HID_MULTITOUCH config HID_NINTENDO tristate "Nintendo Joy-Con and Pro Controller support" depends on HID + depends on NEW_LEDS + depends on LEDS_CLASS help Adds support for the Nintendo Switch Joy-Cons and Pro Controller. All controllers support bluetooth, and the Pro Controller also supports diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c index 882b3758c3be..21d19bc96792 100644 --- a/drivers/hid/hid-nintendo.c +++ b/drivers/hid/hid-nintendo.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include @@ -178,11 +179,13 @@ struct joycon_input_report { } __packed; #define JC_MAX_RESP_SIZE (sizeof(struct joycon_input_report) + 35) +#define JC_NUM_LEDS 4 /* Each physical controller is associated with a joycon_ctlr struct */ struct joycon_ctlr { struct hid_device *hdev; struct input_dev *input; + struct led_classdev leds[JC_NUM_LEDS]; enum joycon_ctlr_state ctlr_state; /* The following members are used for synchronous sends/receives */ @@ -517,11 +520,9 @@ static const unsigned int joycon_button_inputs[] = { 0 /* 0 signals end of array */ }; -static DEFINE_MUTEX(joycon_input_num_mutex); static int joycon_input_create(struct joycon_ctlr *ctlr) { struct hid_device *hdev; - static int input_num = 1; const char *name; int ret; int i; @@ -576,6 +577,66 @@ static int joycon_input_create(struct joycon_ctlr *ctlr) if (ret) return ret; + return 0; +} + +static int joycon_player_led_brightness_set(struct led_classdev *led, + enum led_brightness brightness) +{ + struct device *dev = led->dev->parent; + struct hid_device *hdev = to_hid_device(dev); + struct joycon_ctlr *ctlr; + int val = 0; + int i; + int ret; + int num; + + ctlr = hid_get_drvdata(hdev); + if (!ctlr) { + hid_err(hdev, "No controller data\n"); + return -ENODEV; + } + + /* determine which player led this is */ + for (num = 0; num < JC_NUM_LEDS; num++) { + if (&ctlr->leds[num] == led) + break; + } + if (num >= JC_NUM_LEDS) + return -EINVAL; + + mutex_lock(&ctlr->output_mutex); + for (i = 0; i < JC_NUM_LEDS; i++) { + if (i == num) + val |= brightness << i; + else + val |= ctlr->leds[i].brightness << i; + } + ret = joycon_set_player_leds(ctlr, 0, val); + mutex_unlock(&ctlr->output_mutex); + + return ret; +} + +static const char * const joycon_player_led_names[] = { + "player1", + "player2", + "player3", + "player4" +}; + +static DEFINE_MUTEX(joycon_input_num_mutex); +static int joycon_player_leds_create(struct joycon_ctlr *ctlr) +{ + struct hid_device *hdev = ctlr->hdev; + struct device *dev = &hdev->dev; + const char *d_name = dev_name(dev); + struct led_classdev *led; + char *name; + int ret = 0; + int i; + static int input_num = 1; + /* Set the default controller player leds based on controller number */ mutex_lock(&joycon_input_num_mutex); mutex_lock(&ctlr->output_mutex); @@ -583,6 +644,29 @@ static int joycon_input_create(struct joycon_ctlr *ctlr) if (ret) hid_warn(ctlr->hdev, "Failed to set leds; ret=%d\n", ret); mutex_unlock(&ctlr->output_mutex); + + /* configure the player LEDs */ + for (i = 0; i < JC_NUM_LEDS; i++) { + name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s", d_name, + joycon_player_led_names[i]); + if (!name) + return -ENOMEM; + + led = &ctlr->leds[i]; + led->name = name; + led->brightness = ((i + 1) <= input_num) ? LED_ON : LED_OFF; + led->max_brightness = LED_ON; + led->brightness_set_blocking = + joycon_player_led_brightness_set; + led->flags = LED_CORE_SUSPENDRESUME | LED_HW_PLUGGABLE; + + ret = devm_led_classdev_register(&hdev->dev, led); + if (ret) { + hid_err(hdev, "Failed registering %s LED\n", led->name); + break; + } + } + if (++input_num > 4) input_num = 1; mutex_unlock(&joycon_input_num_mutex); @@ -754,6 +838,13 @@ static int nintendo_hid_probe(struct hid_device *hdev, goto err_close; } + /* Initialize the leds */ + ret = joycon_player_leds_create(ctlr); + if (ret) { + hid_err(hdev, "Failed to create leds; ret=%d\n", ret); + goto err_close; + } + ctlr->ctlr_state = JOYCON_CTLR_STATE_READ; hid_dbg(hdev, "probe - success\n");