[PULL,v2,05/13] linux-user/sparc: Use WREG constants in sparc/target_cpu.h
diff mbox series

Message ID 20191106130456.6176-6-laurent@vivier.eu
State New
Headers show
  • [PULL,v2,01/13] linux-user: Support for NETLINK socket options
Related show

Commit Message

Laurent Vivier Nov. 6, 2019, 1:04 p.m. UTC
From: Richard Henderson <richard.henderson@linaro.org>

This fixes a naming bug wherein we used "UREG_FP" to access the
stack pointer.  OTOH, the "UREG_FP" constant was also defined
incorrectly such that it *did* reference the stack pointer.

Note that the kernel legitimately uses the name "FP", because it
utilizes the rolled stack window in processing the system call.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20191106113318.10226-5-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
 linux-user/sparc/target_cpu.h | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff mbox series

diff --git a/linux-user/sparc/target_cpu.h b/linux-user/sparc/target_cpu.h
index 1ffc0ae9f2ec..b30fbc72c43b 100644
--- a/linux-user/sparc/target_cpu.h
+++ b/linux-user/sparc/target_cpu.h
@@ -41,15 +41,9 @@  static inline void cpu_set_tls(CPUSPARCState *env, target_ulong newtls)
     env->gregs[7] = newtls;
-#ifndef UREG_I6
-#define UREG_I6        6
-#ifndef UREG_FP
-#define UREG_FP        UREG_I6
 static inline abi_ulong get_sp_from_cpustate(CPUSPARCState *state)
-    return state->regwptr[UREG_FP];
+    return state->regwptr[WREG_SP];