[01/11] ucm: docs: Add JackName value
diff mbox series

Message ID 20191107015808.26844-1-cujomalainey@chromium.org
State New
Headers show
Series
  • [01/11] ucm: docs: Add JackName value
Related show

Commit Message

Curtis Malainey Nov. 7, 2019, 1:57 a.m. UTC
This field represents the input device name for a jack detection line

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
---
 include/use-case.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kai Vehmanen Nov. 11, 2019, 9:44 a.m. UTC | #1
Hi Curtis,

On Wed, 6 Nov 2019, Curtis Malainey wrote:

> This field represents the input device name for a jack detection line
> 
> Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>

this series looks good to me and I think it's a very good idea to bring 
extensions that have proven useful in Chromium to alsa-lib.

For reviewing, a bit of background context and pointers would probably 
help the wider audience. E.g. I found this very useful:

https://www.chromium.org/chromium-os/chromiumos-design-docs/cras-chromeos-audio-server
-> 
https://docs.google.com/document/d/1AcXZI9dvJBW0Vy6h9vraD7VP9X_MpwHx0eJ6hNc4G_s/edit?usp=sharing

Not directly related to this series, but it would be nice if the 
versioning would be aligned as well (especially now as ucmv2 is being 
proposed).

Br, Kai
Jaroslav Kysela Nov. 11, 2019, 1:26 p.m. UTC | #2
Dne 07. 11. 19 v 2:57 Curtis Malainey napsal(a):
> This field represents the input device name for a jack detection line
> 
> Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> ---
>   include/use-case.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/include/use-case.h b/include/use-case.h
> index 5cb4f31c..2051bd40 100644
> --- a/include/use-case.h
> +++ b/include/use-case.h
> @@ -320,6 +320,8 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
>    *        trick upper software layers to e.g. automatically mute speakers when
>    *        headphones are plugged in, but that's application policy
>    *        configuration that doesn't belong to UCM configuration files.
> + *   - JackName
> + *      - Input name is the input device name for the jack
>    */
>   int snd_use_case_get(snd_use_case_mgr_t *uc_mgr,
>                        const char *identifier,
> 
What is the difference from JackDev ?

				Jaroslav

Patch
diff mbox series

diff --git a/include/use-case.h b/include/use-case.h
index 5cb4f31c..2051bd40 100644
--- a/include/use-case.h
+++ b/include/use-case.h
@@ -320,6 +320,8 @@  int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
  *        trick upper software layers to e.g. automatically mute speakers when
  *        headphones are plugged in, but that's application policy
  *        configuration that doesn't belong to UCM configuration files.
+ *   - JackName
+ *      - Input name is the input device name for the jack
  */
 int snd_use_case_get(snd_use_case_mgr_t *uc_mgr,
                      const char *identifier,