[06/11] ucm: docs: Add DisableSoftwareVolume
diff mbox series

Message ID 20191107015808.26844-6-cujomalainey@chromium.org
State New
Headers show
Series
  • [01/11] ucm: docs: Add JackName value
Related show

Commit Message

Curtis Malainey Nov. 7, 2019, 1:58 a.m. UTC
Some userspace audio servers might default to software volume, this
allows the ucm to force its behaviour

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
---
 include/use-case.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jaroslav Kysela Nov. 11, 2019, 3:22 p.m. UTC | #1
Dne 07. 11. 19 v 2:58 Curtis Malainey napsal(a):
> Some userspace audio servers might default to software volume, this
> allows the ucm to force its behaviour
> 
> Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> ---
>   include/use-case.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/include/use-case.h b/include/use-case.h
> index 05628303..1aeaf9d4 100644
> --- a/include/use-case.h
> +++ b/include/use-case.h
> @@ -334,6 +334,8 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
>    *      - This is used on platform where reported buffer level is not accurate.
>    *        E.g. "512", which holds 512 samples in device buffer. Note: this will
>    *        increase latency.
> + *   - DisableSoftwareVolume
> + *      - Set to "1" to force userspace to use hardware volume controls
>    */
>   int snd_use_case_get(snd_use_case_mgr_t *uc_mgr,
>                        const char *identifier,
> 


My understanding is that if the hardware volume controls are defined in UCM, 
then the UCM user (audio server) should use them. Otherwise, the software 
volume control should be applied. I don't see the reason to have this info 
doubled.

					Jaroslav
Curtis Malainey Nov. 11, 2019, 6:51 p.m. UTC | #2
On Mon, Nov 11, 2019 at 7:22 AM Jaroslav Kysela <perex@perex.cz> wrote:
>
> Dne 07. 11. 19 v 2:58 Curtis Malainey napsal(a):
> > Some userspace audio servers might default to software volume, this
> > allows the ucm to force its behaviour
> >
> > Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> > ---
> >   include/use-case.h | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/include/use-case.h b/include/use-case.h
> > index 05628303..1aeaf9d4 100644
> > --- a/include/use-case.h
> > +++ b/include/use-case.h
> > @@ -334,6 +334,8 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
> >    *      - This is used on platform where reported buffer level is not accurate.
> >    *        E.g. "512", which holds 512 samples in device buffer. Note: this will
> >    *        increase latency.
> > + *   - DisableSoftwareVolume
> > + *      - Set to "1" to force userspace to use hardware volume controls
> >    */
> >   int snd_use_case_get(snd_use_case_mgr_t *uc_mgr,
> >                        const char *identifier,
> >
>
>
> My understanding is that if the hardware volume controls are defined in UCM,
> then the UCM user (audio server) should use them. Otherwise, the software
> volume control should be applied. I don't see the reason to have this info
> doubled.
>
>                                         Jaroslav
>
+Jimmy Cheng-Yi Chiang can you clarify in what context CRAS might need
this value? The only cases I see are for Chat 150 C and Jabra SPEAK
810. There are no volume mixers associated with these files.
> --
> Jaroslav Kysela <perex@perex.cz>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
Curtis Malainey Nov. 11, 2019, 7:11 p.m. UTC | #3
On Mon, Nov 11, 2019 at 10:51 AM Curtis Malainey
<cujomalainey@google.com> wrote:
>
> On Mon, Nov 11, 2019 at 7:22 AM Jaroslav Kysela <perex@perex.cz> wrote:
> >
> > Dne 07. 11. 19 v 2:58 Curtis Malainey napsal(a):
> > > Some userspace audio servers might default to software volume, this
> > > allows the ucm to force its behaviour
> > >
> > > Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> > > ---
> > >   include/use-case.h | 2 ++
> > >   1 file changed, 2 insertions(+)
> > >
> > > diff --git a/include/use-case.h b/include/use-case.h
> > > index 05628303..1aeaf9d4 100644
> > > --- a/include/use-case.h
> > > +++ b/include/use-case.h
> > > @@ -334,6 +334,8 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
> > >    *      - This is used on platform where reported buffer level is not accurate.
> > >    *        E.g. "512", which holds 512 samples in device buffer. Note: this will
> > >    *        increase latency.
> > > + *   - DisableSoftwareVolume
> > > + *      - Set to "1" to force userspace to use hardware volume controls
> > >    */
> > >   int snd_use_case_get(snd_use_case_mgr_t *uc_mgr,
> > >                        const char *identifier,
> > >
> >
> >
> > My understanding is that if the hardware volume controls are defined in UCM,
> > then the UCM user (audio server) should use them. Otherwise, the software
> > volume control should be applied. I don't see the reason to have this info
> > doubled.
> >
> >                                         Jaroslav
> >
> +Jimmy Cheng-Yi Chiang can you clarify in what context CRAS might need
> this value? The only cases I see are for Chat 150 C and Jabra SPEAK
> 810. There are no volume mixers associated with these files.
+Jimmy Cheng-Yi Chiang retry adding Jimmy to email chain
> > --
> > Jaroslav Kysela <perex@perex.cz>
> > Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

Patch
diff mbox series

diff --git a/include/use-case.h b/include/use-case.h
index 05628303..1aeaf9d4 100644
--- a/include/use-case.h
+++ b/include/use-case.h
@@ -334,6 +334,8 @@  int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
  *      - This is used on platform where reported buffer level is not accurate.
  *        E.g. "512", which holds 512 samples in device buffer. Note: this will
  *        increase latency.
+ *   - DisableSoftwareVolume
+ *      - Set to "1" to force userspace to use hardware volume controls
  */
 int snd_use_case_get(snd_use_case_mgr_t *uc_mgr,
                      const char *identifier,