[07/11] ucm: docs: Add CaptureChannelMap
diff mbox series

Message ID 20191107015808.26844-7-cujomalainey@chromium.org
State New
Headers show
Series
  • [01/11] ucm: docs: Add JackName value
Related show

Commit Message

Curtis Malainey Nov. 7, 2019, 1:58 a.m. UTC
Add ucm value to tell userspace to remap channels. This is useful for
systems with DMICs where there may be more channels than active
channels.

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
---
 include/use-case.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jaroslav Kysela Nov. 11, 2019, 3:30 p.m. UTC | #1
Dne 07. 11. 19 v 2:58 Curtis Malainey napsal(a):
> Add ucm value to tell userspace to remap channels. This is useful for
> systems with DMICs where there may be more channels than active
> channels.
> 
> Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> ---
>   include/use-case.h | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/include/use-case.h b/include/use-case.h
> index 1aeaf9d4..31f9e4be 100644
> --- a/include/use-case.h
> +++ b/include/use-case.h
> @@ -301,6 +301,10 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
>    *      - name of capture mixer
>    *   - CaptureMixerID
>    *      - mixer capture ID
> + *   - CaptureChannelMap
> + *      - Remap channels using ALSA PCM channel mapping API notation
> + *        E.g. "2 3 0 1 -1 -1 -1 -1 -1 -1 -1" means, FL takes channel 2,
> + *        FR takes channel 3, RL takes channel 0, RL takes channel 1.
>    *   - EDIDFile
>    *      - Path to EDID file for HDMI devices
>    *   - JackControl, JackDev, JackHWMute
> 

I see a room for the improvement to have a better and complete mapping 
description like:

CaptureChannelMap "FR=0 RL=1 TC=2"

The location names should follow SND_CHMAP defines.

					Jaroslav
Curtis Malainey Nov. 11, 2019, 10:08 p.m. UTC | #2
On Mon, Nov 11, 2019 at 7:30 AM Jaroslav Kysela <perex@perex.cz> wrote:
>
> Dne 07. 11. 19 v 2:58 Curtis Malainey napsal(a):
> > Add ucm value to tell userspace to remap channels. This is useful for
> > systems with DMICs where there may be more channels than active
> > channels.
> >
> > Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> > ---
> >   include/use-case.h | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/include/use-case.h b/include/use-case.h
> > index 1aeaf9d4..31f9e4be 100644
> > --- a/include/use-case.h
> > +++ b/include/use-case.h
> > @@ -301,6 +301,10 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
> >    *      - name of capture mixer
> >    *   - CaptureMixerID
> >    *      - mixer capture ID
> > + *   - CaptureChannelMap
> > + *      - Remap channels using ALSA PCM channel mapping API notation
> > + *        E.g. "2 3 0 1 -1 -1 -1 -1 -1 -1 -1" means, FL takes channel 2,
> > + *        FR takes channel 3, RL takes channel 0, RL takes channel 1.
> >    *   - EDIDFile
> >    *      - Path to EDID file for HDMI devices
> >    *   - JackControl, JackDev, JackHWMute
> >
>
> I see a room for the improvement to have a better and complete mapping
> description like:
>
> CaptureChannelMap "FR=0 RL=1 TC=2"
>
> The location names should follow SND_CHMAP defines.
>
>                                         Jaroslav
>
I am definitely for that modification as the mapping for the plugin is
not easy to read, that being said, do we have a tool to handle
parsing/converting that from a string already? I feel like we should
add one if we are going to make that the spec.
> --
> Jaroslav Kysela <perex@perex.cz>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

Patch
diff mbox series

diff --git a/include/use-case.h b/include/use-case.h
index 1aeaf9d4..31f9e4be 100644
--- a/include/use-case.h
+++ b/include/use-case.h
@@ -301,6 +301,10 @@  int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
  *      - name of capture mixer
  *   - CaptureMixerID
  *      - mixer capture ID
+ *   - CaptureChannelMap
+ *      - Remap channels using ALSA PCM channel mapping API notation
+ *        E.g. "2 3 0 1 -1 -1 -1 -1 -1 -1 -1" means, FL takes channel 2,
+ *        FR takes channel 3, RL takes channel 0, RL takes channel 1.
  *   - EDIDFile
  *      - Path to EDID file for HDMI devices
  *   - JackControl, JackDev, JackHWMute