[09/11] ucm: docs: Add EchoReferenceDev
diff mbox series

Message ID 20191107015808.26844-9-cujomalainey@chromium.org
State New
Headers show
Series
  • [01/11] ucm: docs: Add JackName value
Related show

Commit Message

Curtis Malainey Nov. 7, 2019, 1:58 a.m. UTC
Sometimes userspace may want to use a reference channel to cancel echos
when using video chat, this value identifies the device which carries
that channel.

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
---
 include/use-case.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jaroslav Kysela Nov. 11, 2019, 3:36 p.m. UTC | #1
Dne 07. 11. 19 v 2:58 Curtis Malainey napsal(a):
> Sometimes userspace may want to use a reference channel to cancel echos
> when using video chat, this value identifies the device which carries
> that channel.
> 
> Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> ---
>   include/use-case.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/include/use-case.h b/include/use-case.h
> index 9a10f390..e84f3f8f 100644
> --- a/include/use-case.h
> +++ b/include/use-case.h
> @@ -308,6 +308,9 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
>    *   - CoupledMixers
>    *      - Mixer controls that should be changed together.
>    *        E.g. "Left Master,Right Master".
> + *   - EchoReferenceDev
> + *      - If userspace wants an echo refence channel this value identifies the
> + *        device to be used.
>    *   - EDIDFile
>    *      - Path to EDID file for HDMI devices
>    *   - JackControl, JackDev, JackHWMute
> 

It's PCM device name like PlaybackPCM ? I would rename this to 
EchoReferencePCM then.

					Jaroslav
Curtis Malainey Nov. 11, 2019, 6:42 p.m. UTC | #2
On Mon, Nov 11, 2019 at 7:36 AM Jaroslav Kysela <perex@perex.cz> wrote:
>
> Dne 07. 11. 19 v 2:58 Curtis Malainey napsal(a):
> > Sometimes userspace may want to use a reference channel to cancel echos
> > when using video chat, this value identifies the device which carries
> > that channel.
> >
> > Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> > ---
> >   include/use-case.h | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/include/use-case.h b/include/use-case.h
> > index 9a10f390..e84f3f8f 100644
> > --- a/include/use-case.h
> > +++ b/include/use-case.h
> > @@ -308,6 +308,9 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
> >    *   - CoupledMixers
> >    *      - Mixer controls that should be changed together.
> >    *        E.g. "Left Master,Right Master".
> > + *   - EchoReferenceDev
> > + *      - If userspace wants an echo refence channel this value identifies the
> > + *        device to be used.
> >    *   - EDIDFile
> >    *      - Path to EDID file for HDMI devices
> >    *   - JackControl, JackDev, JackHWMute
> >
>
> It's PCM device name like PlaybackPCM ? I would rename this to
> EchoReferencePCM then.
>
>                                         Jaroslav
Not quite. The name associated is another SectionDevice.
Although I will have to send a v2 for this patch as I noticed a typo "refence"
>
> --
> Jaroslav Kysela <perex@perex.cz>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

Patch
diff mbox series

diff --git a/include/use-case.h b/include/use-case.h
index 9a10f390..e84f3f8f 100644
--- a/include/use-case.h
+++ b/include/use-case.h
@@ -308,6 +308,9 @@  int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
  *   - CoupledMixers
  *      - Mixer controls that should be changed together.
  *        E.g. "Left Master,Right Master".
+ *   - EchoReferenceDev
+ *      - If userspace wants an echo refence channel this value identifies the
+ *        device to be used.
  *   - EDIDFile
  *      - Path to EDID file for HDMI devices
  *   - JackControl, JackDev, JackHWMute