| Message ID | 20191108092824.9773-7-rnayak@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8e4d5a5bde8896c7fa36b173c613dbbbf9d5dc32 |
| Headers | show |
| Series | Add device tree support for sc7180 | expand |
On 2019-11-08 10:37, Rajendra Nayak wrote: > Remove the sdm845 SoC specific compatible to make the driver > easily reusable across other SoC's with the same IP block. > This will reduce further churn adding any SoC specific > compatibles unless really needed. > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> > Reviewed-by: Lina Iyer <ilina@codeaurora.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Cc: Marc Zyngier <maz@kernel.org> > --- > drivers/irqchip/qcom-pdc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > index faa7d61b9d6c..c175333bb646 100644 > --- a/drivers/irqchip/qcom-pdc.c > +++ b/drivers/irqchip/qcom-pdc.c > @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node > *node, struct device_node *parent) > return ret; > } > > -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init); > +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init); Acked-by: Marc Zyngier <marc.zyngier@arm.com> How do you want me get this (and the DT change) merged? I can either take these two patches in the irqchip tree, or you arrange them to be taken by the platform maintainers. Your call. Thanks, M.
On 2019-11-08 10:50, Marc Zyngier wrote: > On 2019-11-08 10:37, Rajendra Nayak wrote: >> Remove the sdm845 SoC specific compatible to make the driver >> easily reusable across other SoC's with the same IP block. >> This will reduce further churn adding any SoC specific >> compatibles unless really needed. >> >> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> >> Reviewed-by: Lina Iyer <ilina@codeaurora.org> >> Reviewed-by: Stephen Boyd <swboyd@chromium.org> >> Cc: Marc Zyngier <maz@kernel.org> >> --- >> drivers/irqchip/qcom-pdc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c >> index faa7d61b9d6c..c175333bb646 100644 >> --- a/drivers/irqchip/qcom-pdc.c >> +++ b/drivers/irqchip/qcom-pdc.c >> @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node >> *node, struct device_node *parent) >> return ret; >> } >> >> -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init); >> +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init); > > Acked-by: Marc Zyngier <marc.zyngier@arm.com> I need to have my hands fixed. The real tag is: Acked-by: Marc Zyngier <maz@kernel.org> One day, I'll manage that... M.
On 11/8/2019 3:10 PM, Marc Zyngier wrote: > On 2019-11-08 10:37, Rajendra Nayak wrote: >> Remove the sdm845 SoC specific compatible to make the driver >> easily reusable across other SoC's with the same IP block. >> This will reduce further churn adding any SoC specific >> compatibles unless really needed. >> >> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> >> Reviewed-by: Lina Iyer <ilina@codeaurora.org> >> Reviewed-by: Stephen Boyd <swboyd@chromium.org> >> Cc: Marc Zyngier <maz@kernel.org> >> --- >> drivers/irqchip/qcom-pdc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c >> index faa7d61b9d6c..c175333bb646 100644 >> --- a/drivers/irqchip/qcom-pdc.c >> +++ b/drivers/irqchip/qcom-pdc.c >> @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node >> *node, struct device_node *parent) >> return ret; >> } >> >> -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init); >> +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init); > > Acked-by: Marc Zyngier <marc.zyngier@arm.com> > > How do you want me get this (and the DT change) merged? I can either take > these two patches in the irqchip tree, or you arrange them to be taken > by the platform maintainers. Your call. I think it makes sense for you to take these two via your tree (The driver and binding doc updates) and the DT node addition for pdc to go via Andy/Bjorn. Andy/Bjorn, does that sound fine?
On Fri 08 Nov 01:55 PST 2019, Rajendra Nayak wrote: > > On 11/8/2019 3:10 PM, Marc Zyngier wrote: > > On 2019-11-08 10:37, Rajendra Nayak wrote: > > > Remove the sdm845 SoC specific compatible to make the driver > > > easily reusable across other SoC's with the same IP block. > > > This will reduce further churn adding any SoC specific > > > compatibles unless really needed. > > > > > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> > > > Reviewed-by: Lina Iyer <ilina@codeaurora.org> > > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > > Cc: Marc Zyngier <maz@kernel.org> > > > --- > > > drivers/irqchip/qcom-pdc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > > > index faa7d61b9d6c..c175333bb646 100644 > > > --- a/drivers/irqchip/qcom-pdc.c > > > +++ b/drivers/irqchip/qcom-pdc.c > > > @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node > > > *node, struct device_node *parent) > > > return ret; > > > } > > > > > > -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init); > > > +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init); > > > > Acked-by: Marc Zyngier <marc.zyngier@arm.com> > > > > How do you want me get this (and the DT change) merged? I can either take > > these two patches in the irqchip tree, or you arrange them to be taken > > by the platform maintainers. Your call. > > I think it makes sense for you to take these two via your tree (The driver > and binding doc updates) and the DT node addition for pdc to go via Andy/Bjorn. > Andy/Bjorn, does that sound fine? > Yes, that sounds good. Regards, Bjorn
On 2019-11-11 08:19, Bjorn Andersson wrote: > On Fri 08 Nov 01:55 PST 2019, Rajendra Nayak wrote: > >> >> On 11/8/2019 3:10 PM, Marc Zyngier wrote: >> > On 2019-11-08 10:37, Rajendra Nayak wrote: >> > > Remove the sdm845 SoC specific compatible to make the driver >> > > easily reusable across other SoC's with the same IP block. >> > > This will reduce further churn adding any SoC specific >> > > compatibles unless really needed. >> > > >> > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> >> > > Reviewed-by: Lina Iyer <ilina@codeaurora.org> >> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> >> > > Cc: Marc Zyngier <maz@kernel.org> >> > > --- >> > > drivers/irqchip/qcom-pdc.c | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > diff --git a/drivers/irqchip/qcom-pdc.c >> b/drivers/irqchip/qcom-pdc.c >> > > index faa7d61b9d6c..c175333bb646 100644 >> > > --- a/drivers/irqchip/qcom-pdc.c >> > > +++ b/drivers/irqchip/qcom-pdc.c >> > > @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node >> > > *node, struct device_node *parent) >> > > return ret; >> > > } >> > > >> > > -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init); >> > > +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init); >> > >> > Acked-by: Marc Zyngier <marc.zyngier@arm.com> >> > >> > How do you want me get this (and the DT change) merged? I can >> either take >> > these two patches in the irqchip tree, or you arrange them to be >> taken >> > by the platform maintainers. Your call. >> >> I think it makes sense for you to take these two via your tree (The >> driver >> and binding doc updates) and the DT node addition for pdc to go via >> Andy/Bjorn. >> Andy/Bjorn, does that sound fine? >> > > Yes, that sounds good. Applied to irqchip/next M.
diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c index faa7d61b9d6c..c175333bb646 100644 --- a/drivers/irqchip/qcom-pdc.c +++ b/drivers/irqchip/qcom-pdc.c @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node *node, struct device_node *parent) return ret; } -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init); +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);