ALSA: pcm: Yet another missing check of non-cached buffer type
diff mbox series

Message ID
State New
Headers show
  • ALSA: pcm: Yet another missing check of non-cached buffer type
Related show

Commit Message

Takashi Iwai Nov. 8, 2019, 4:56 p.m. UTC
For non-x86 architectures, SNDRV_DMA_TYPE_DEV_UC should be treated
equivalent with SNDRV_DMA_TYPE_DEV, where the default mmap handler
still checks only about SNDRV_DMA_TYPE_DEV.  Make the check more

Note that all existing users of *_UC buffer types are x86-only, so
this doesn't fix any bug, but just for consistency.

Fixes: 42e748a0b325 ("ALSA: memalloc: Add non-cached buffer type")
Signed-off-by: Takashi Iwai <>
 sound/core/pcm_native.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox series

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 998c63192ae4..0c27009dc3df 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -3416,7 +3416,8 @@  int snd_pcm_lib_default_mmap(struct snd_pcm_substream *substream,
 #ifndef CONFIG_X86 /* for avoiding warnings arch/x86/mm/pat.c */
 	if (IS_ENABLED(CONFIG_HAS_DMA) && !substream->ops->page &&
-	    substream-> == SNDRV_DMA_TYPE_DEV)
+	    (substream-> == SNDRV_DMA_TYPE_DEV ||
+	     substream-> == SNDRV_DMA_TYPE_DEV_UC))
 		return dma_mmap_coherent(substream->,