| Message ID | 20191109033634.30544-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,-next] fsi: aspeed: Use devm_kfree in aspeed_master_release() | expand |
On 11/8/19 7:36 PM, YueHaibing wrote: > 'aspeed' is allocated by devm_kzalloc(), it should not be > freed by kfree(). > > Fixes: 1edac1269c02 ("fsi: Add ast2600 master driver") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v2: fix log typos > --- > drivers/fsi/fsi-master-aspeed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c > index 3dd82dd..0f63eec 100644 > --- a/drivers/fsi/fsi-master-aspeed.c > +++ b/drivers/fsi/fsi-master-aspeed.c > @@ -361,7 +361,7 @@ static void aspeed_master_release(struct device *dev) > struct fsi_master_aspeed *aspeed = > to_fsi_master_aspeed(dev_to_fsi_master(dev)); > > - kfree(aspeed); > + devm_kfree(dev, aspeed); > } > > /* mmode encoders */ > Same question as before: Why is there a release function in the first place ? Guenter
diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c index 3dd82dd..0f63eec 100644 --- a/drivers/fsi/fsi-master-aspeed.c +++ b/drivers/fsi/fsi-master-aspeed.c @@ -361,7 +361,7 @@ static void aspeed_master_release(struct device *dev) struct fsi_master_aspeed *aspeed = to_fsi_master_aspeed(dev_to_fsi_master(dev)); - kfree(aspeed); + devm_kfree(dev, aspeed); } /* mmode encoders */
'aspeed' is allocated by devm_kzalloc(), it should not be freed by kfree(). Fixes: 1edac1269c02 ("fsi: Add ast2600 master driver") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v2: fix log typos --- drivers/fsi/fsi-master-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)