| Message ID | 20191111014946.54533-1-houtao1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: genhd: skip blk_register_region() for disk using ext-dev | expand |
ping ? On 2019/11/11 9:49, Hou Tao wrote: > It doesn't incur any harm now when the range parameter of > blk_register_region() is zero, but let's skip the useless call of > blk_register_region() for disk which uses ext-dev. > > Signed-off-by: Hou Tao <houtao1@huawei.com> > --- > block/genhd.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/block/genhd.c b/block/genhd.c > index 26b31fcae217..c61b59b550b0 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -739,8 +739,9 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk, > ret = bdi_register_owner(disk->queue->backing_dev_info, > disk_to_dev(disk)); > WARN_ON(ret); > - blk_register_region(disk_devt(disk), disk->minors, NULL, > - exact_match, exact_lock, disk); > + if (disk->minors) > + blk_register_region(disk_devt(disk), disk->minors, NULL, > + exact_match, exact_lock, disk); > } > register_disk(parent, disk, groups); > if (register_queue) >
diff --git a/block/genhd.c b/block/genhd.c index 26b31fcae217..c61b59b550b0 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -739,8 +739,9 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk, ret = bdi_register_owner(disk->queue->backing_dev_info, disk_to_dev(disk)); WARN_ON(ret); - blk_register_region(disk_devt(disk), disk->minors, NULL, - exact_match, exact_lock, disk); + if (disk->minors) + blk_register_region(disk_devt(disk), disk->minors, NULL, + exact_match, exact_lock, disk); } register_disk(parent, disk, groups); if (register_queue)
It doesn't incur any harm now when the range parameter of blk_register_region() is zero, but let's skip the useless call of blk_register_region() for disk which uses ext-dev. Signed-off-by: Hou Tao <houtao1@huawei.com> --- block/genhd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)