drm/i915/gen9: Add missing 10bpc formats
diff mbox series

Message ID 20191111035241.19014-1-kishore.kadiyala@intel.com
State New
Headers show
Series
  • drm/i915/gen9: Add missing 10bpc formats
Related show

Commit Message

Kishore Kadiyala Nov. 11, 2019, 3:52 a.m. UTC
Add 10bpc formats for gen9.
This patch has dependency on below patch:
https://patchwork.freedesktop.org/patch/335029/?series=67741&rev=2

Signed-off-by: Kishore Kadiyala <kishore.kadiyala@intel.com>
---
 drivers/gpu/drm/i915/display/intel_sprite.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ville Syrjälä Nov. 11, 2019, 2:03 p.m. UTC | #1
On Mon, Nov 11, 2019 at 09:22:41AM +0530, Kishore Kadiyala wrote:
> Add 10bpc formats for gen9.
> This patch has dependency on below patch:
> https://patchwork.freedesktop.org/patch/335029/?series=67741&rev=2
> 
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_sprite.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> index d7f71fa90659..fad73ea00992 100644
> --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> @@ -2444,6 +2444,8 @@ static const u32 skl_planar_formats[] = {
>  	DRM_FORMAT_ABGR8888,
>  	DRM_FORMAT_XRGB2101010,
>  	DRM_FORMAT_XBGR2101010,
> +	DRM_FORMAT_ARGB2101010,
> +	DRM_FORMAT_ABGR2101010,

Nope. Alpha blending is not supported with 10bpc formats on pre-icl
platforms.

>  	DRM_FORMAT_XRGB16161616F,
>  	DRM_FORMAT_XBGR16161616F,
>  	DRM_FORMAT_YUYV,
> -- 
> 2.17.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Kishore Kadiyala Nov. 13, 2019, 6:27 a.m. UTC | #2
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Monday, November 11, 2019 7:34 PM
> To: Kadiyala, Kishore <kishore.kadiyala@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/gen9: Add missing 10bpc formats
> 
> On Mon, Nov 11, 2019 at 09:22:41AM +0530, Kishore Kadiyala wrote:
> > Add 10bpc formats for gen9.
> > This patch has dependency on below patch:
> > https://patchwork.freedesktop.org/patch/335029/?series=67741&rev=2
> >
> > Signed-off-by: Kishore Kadiyala <kishore.kadiyala@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_sprite.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c
> > b/drivers/gpu/drm/i915/display/intel_sprite.c
> > index d7f71fa90659..fad73ea00992 100644
> > --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> > @@ -2444,6 +2444,8 @@ static const u32 skl_planar_formats[] = {
> >  	DRM_FORMAT_ABGR8888,
> >  	DRM_FORMAT_XRGB2101010,
> >  	DRM_FORMAT_XBGR2101010,
> > +	DRM_FORMAT_ARGB2101010,
> > +	DRM_FORMAT_ABGR2101010,
> 
> Nope. Alpha blending is not supported with 10bpc formats on pre-icl platforms.

I have checked the capabilities for Gen9 and as you pointed Alpha is not supported for 10bpc formats.
This patch can be dropped.

> 
> >  	DRM_FORMAT_XRGB16161616F,
> >  	DRM_FORMAT_XBGR16161616F,
> >  	DRM_FORMAT_YUYV,
> > --
> > 2.17.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> --
> Ville Syrjälä
> Intel

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index d7f71fa90659..fad73ea00992 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -2444,6 +2444,8 @@  static const u32 skl_planar_formats[] = {
 	DRM_FORMAT_ABGR8888,
 	DRM_FORMAT_XRGB2101010,
 	DRM_FORMAT_XBGR2101010,
+	DRM_FORMAT_ARGB2101010,
+	DRM_FORMAT_ABGR2101010,
 	DRM_FORMAT_XRGB16161616F,
 	DRM_FORMAT_XBGR16161616F,
 	DRM_FORMAT_YUYV,