From patchwork Mon Nov 11 20:55:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 11237717 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9AEC715AB for ; Mon, 11 Nov 2019 20:56:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71787206A3 for ; Mon, 11 Nov 2019 20:56:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="O4h8Zkj8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71787206A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUGiY-0000yf-0p; Mon, 11 Nov 2019 20:55:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUGiW-0000ya-P8 for xen-devel@lists.xenproject.org; Mon, 11 Nov 2019 20:55:20 +0000 X-Inumbo-ID: 914cf33c-04c5-11ea-a219-12813bfff9fa Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 914cf33c-04c5-11ea-a219-12813bfff9fa; Mon, 11 Nov 2019 20:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1573505719; h=from:to:cc:subject:date:message-id:mime-version; bh=X7N8N5j3TbS0A03KtmkM+8wnCK8YcLEFlb0XqGT7JS0=; b=O4h8Zkj8LaE6iK344wXBeK2pZDg2fSbKh0cW03uFMxSUM1FupXm720ws dGeezS1zTtAe0u/rOZqjXjc+UFP8YuPWTsrQHVce3CvurKzBaVmqKo4K9 Sa5/PKSm0a4kwrqLJ9rT+WsyqdS9ITGVwW3h49DnnysoefklwT9b72C7e Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: HYiBlN1acpkIYYPk+hQulzDR2si6wL+vLynDb1l0xwjGv2bxjXMmkC4U8l76zYuXEUcWiq1CVq 3c54gYhWZijx+QGYcVE8VEy2CYls7dAPYhNO5CGyhrbnnObd8w00JFh+6/BMIOQqTJIaBiEYLd S5VlnSwcLSGwU7QQsXJ+Wq0fP0713gKuy+FsQJ6Q8PdCT4V9B2kHnNEcLLtWqI2uk3Ukda67RQ Y92kp9AE6p+FfhfhOtdliH+njBeWChyUDcj7wrTbVcT8kQBUxtEe7JskkCie094Z7tPlEn9oed hgY= X-SBRS: 2.7 X-MesageID: 8268646 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,293,1569297600"; d="scan'208";a="8268646" From: Andrew Cooper To: Xen-devel Date: Mon, 11 Nov 2019 20:55:14 +0000 Message-ID: <20191111205514.2779-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] AMD/IOMMU: Fix passthrough following c/s d7cfeb7c13e X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Andrew Cooper , Jennifer Herbert , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" "AMD/IOMMU: don't blindly allocate interrupt remapping tables" introduces a call at runtime from amd_iommu_add_device() to amd_iommu_set_intremap_table() which is still marked as __init. On one AMD Rome machine we have, this results in a crash the moment we try to use an SR-IOV VF in a VM. Reported-by: Jennifer Herbert Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Tested-by: Jennifer Herbert --- CC: Jan Beulich CC: Juergen Gross For 4.13. This is a regression vs 4.12 --- xen/drivers/passthrough/amd/iommu_map.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c index 2859d8257e..f3fcfb9e0f 100644 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -112,7 +112,7 @@ void amd_iommu_set_root_page_table(struct amd_iommu_dte *dte, dte->v = valid; } -void __init amd_iommu_set_intremap_table( +void amd_iommu_set_intremap_table( struct amd_iommu_dte *dte, const void *ptr, const struct amd_iommu *iommu, bool valid) {