HID: quirks: remove hid-led devices from hid_have_special_driver
diff mbox series

Message ID dee18394-b0cb-8f85-2db3-9e07407184ba@gmail.com
State Mainlined
Commit b03e5774d51fe003e1020060c403a1d085b128eb
Delegated to: Benjamin Tissoires
Headers show
Series
  • HID: quirks: remove hid-led devices from hid_have_special_driver
Related show

Commit Message

Heiner Kallweit Nov. 11, 2019, 9:38 p.m. UTC
Since e04a0442d33b ("HID: core: remove the absolute need of
hid_have_special_driver[]") it's no longer needed to list these LED
devices in hid_have_special_driver[]. This allows libraries needing
access to the hidraw device to work properly.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/hid/hid-quirks.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Benjamin Tissoires Nov. 18, 2019, 10:02 a.m. UTC | #1
On Mon, Nov 11, 2019 at 10:38 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> Since e04a0442d33b ("HID: core: remove the absolute need of
> hid_have_special_driver[]") it's no longer needed to list these LED
> devices in hid_have_special_driver[]. This allows libraries needing
> access to the hidraw device to work properly.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---

Applied to for-5.5/core.

Thanks a lot for the submission.

Cheers,
Benjamin

>  drivers/hid/hid-quirks.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
> index c50bcd967..bdaab79f7 100644
> --- a/drivers/hid/hid-quirks.c
> +++ b/drivers/hid/hid-quirks.c
> @@ -419,13 +419,6 @@ static const struct hid_device_id hid_have_special_driver[] = {
>  #if IS_ENABLED(CONFIG_HID_LCPOWER)
>         { HID_USB_DEVICE(USB_VENDOR_ID_LCPOWER, USB_DEVICE_ID_LCPOWER_LC1000) },
>  #endif
> -#if IS_ENABLED(CONFIG_HID_LED)
> -       { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, USB_DEVICE_ID_DREAM_CHEEKY_WN) },
> -       { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, USB_DEVICE_ID_DREAM_CHEEKY_FA) },
> -       { HID_USB_DEVICE(USB_VENDOR_ID_MICROCHIP, USB_DEVICE_ID_LUXAFOR) },
> -       { HID_USB_DEVICE(USB_VENDOR_ID_RISO_KAGAKU, USB_DEVICE_ID_RI_KA_WEBMAIL) },
> -       { HID_USB_DEVICE(USB_VENDOR_ID_THINGM, USB_DEVICE_ID_BLINK1) },
> -#endif
>  #if IS_ENABLED(CONFIG_HID_LENOVO)
>         { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_TPKBD) },
>         { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_CUSBKBD) },
> --
> 2.24.0
>

Patch
diff mbox series

diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
index c50bcd967..bdaab79f7 100644
--- a/drivers/hid/hid-quirks.c
+++ b/drivers/hid/hid-quirks.c
@@ -419,13 +419,6 @@  static const struct hid_device_id hid_have_special_driver[] = {
 #if IS_ENABLED(CONFIG_HID_LCPOWER)
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LCPOWER, USB_DEVICE_ID_LCPOWER_LC1000) },
 #endif
-#if IS_ENABLED(CONFIG_HID_LED)
-	{ HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, USB_DEVICE_ID_DREAM_CHEEKY_WN) },
-	{ HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, USB_DEVICE_ID_DREAM_CHEEKY_FA) },
-	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROCHIP, USB_DEVICE_ID_LUXAFOR) },
-	{ HID_USB_DEVICE(USB_VENDOR_ID_RISO_KAGAKU, USB_DEVICE_ID_RI_KA_WEBMAIL) },
-	{ HID_USB_DEVICE(USB_VENDOR_ID_THINGM, USB_DEVICE_ID_BLINK1) },
-#endif
 #if IS_ENABLED(CONFIG_HID_LENOVO)
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_TPKBD) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_CUSBKBD) },