arm64: dts: rockchip: rockpro64: fix ES8316 i2c address
diff mbox series

Message ID 20191112011521.3155504-1-anarsoul@gmail.com
State New
Headers show
Series
  • arm64: dts: rockchip: rockpro64: fix ES8316 i2c address
Related show

Commit Message

Vasily Khoruzhick Nov. 12, 2019, 1:15 a.m. UTC
According to Rockpro64 schematics [1] CE pin of ES8316 is wired
to ground, so codec address should be 0x10.

[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf

Fixes: 6860769ea771 ("arm64: dts: rockchip: add analog audio nodes on rk3399-rockpro64")
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Vasily Khoruzhick Nov. 12, 2019, 7:38 a.m. UTC | #1
On Mon, Nov 11, 2019 at 5:15 PM Vasily Khoruzhick <anarsoul@gmail.com> wrote:
>
> According to Rockpro64 schematics [1] CE pin of ES8316 is wired
> to ground, so codec address should be 0x10.
>
> [1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf

Please don't merge it yet, it appears that on Katsuhiro's board codec
is at address 0x11.

> Fixes: 6860769ea771 ("arm64: dts: rockchip: add analog audio nodes on rk3399-rockpro64")
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> index 7f4b2eba31d4..18bbe548839b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
> @@ -477,9 +477,9 @@
>         i2c-scl-falling-time-ns = <15>;
>         status = "okay";
>
> -       es8316: codec@11 {
> +       es8316: codec@10 {
>                 compatible = "everest,es8316";
> -               reg = <0x11>;
> +               reg = <0x10>;
>                 clocks = <&cru SCLK_I2S_8CH_OUT>;
>                 clock-names = "mclk";
>                 #sound-dai-cells = <0>;
> --
> 2.23.0
>

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
index 7f4b2eba31d4..18bbe548839b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
@@ -477,9 +477,9 @@ 
 	i2c-scl-falling-time-ns = <15>;
 	status = "okay";
 
-	es8316: codec@11 {
+	es8316: codec@10 {
 		compatible = "everest,es8316";
-		reg = <0x11>;
+		reg = <0x10>;
 		clocks = <&cru SCLK_I2S_8CH_OUT>;
 		clock-names = "mclk";
 		#sound-dai-cells = <0>;