From patchwork Tue Nov 12 06:51:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?Q2h1bmZlbmcgWXVuICjkupHmmKXls7Ap?= X-Patchwork-Id: 11238721 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BDBCD13B1 for ; Tue, 12 Nov 2019 06:53:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77139206A3 for ; Tue, 12 Nov 2019 06:53:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D76vJMDI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="tVTqjYY0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77139206A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ZJ4vLfPOax3S/JjjPodW4FaRuuJmtRXhbUQOITtwYEQ=; b=D76vJMDIzLDNlN lpQ8q/RvSahZM6sfw16ZulqbHwwSq3TAH/gDIhUObcmtuJPnUOiEu4X6CvMKPMzblqble8mMCV71R 86gH/BF9T9VRyvOIjXXpt1KwRWFK1ygMipI2vzp2SZeKfAW8nShvnLD6w3vh0jgdzlHRvVxfuydrg hWxhbC1c55xROAdEfZufCjW6Wnz4bHUEoZEG1tDuh4TVu4Fq8B5hO1QaCicGT7Mc3m2G+/i1OWBGu 7uMfMZ7HwbUEOthaJI1SosA7agc2wTpR1n/F2BCBD0gjQmhSdNJLCIpWx0q5+8rHxY+Dcfb4tNjJd wjWHpTrt2jKbjgF8bpVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUQ3g-0004D8-Nz; Tue, 12 Nov 2019 06:53:48 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUQ2P-0002xH-2w; Tue, 12 Nov 2019 06:52:30 +0000 X-UUID: c1a194e6fbee4f33b11990e42cdc0aae-20191111 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=d8BFCFk1jWo76KszBymxQCa+dx51d98IKSWXcuFIpgA=; b=tVTqjYY0oyDh+277mNVItkS0IaGKvK/um7WCvmTZWwwYkLZTgfp2dlxk/J4DOOtcSRCuTtTCp13zAUn+DwlaQNuQHUBLZ5nZX6krk8cWUlQ3lhS8qVSx3uynmgXlJ3a2oofHWov7xfaR+ndbWMt/eRNzhZXodRKhKwnl1w/m/xc=; X-UUID: c1a194e6fbee4f33b11990e42cdc0aae-20191111 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2147101652; Mon, 11 Nov 2019 22:52:26 -0800 Received: from mtkmbs08n1.mediatek.inc (172.21.101.55) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Nov 2019 22:52:04 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 12 Nov 2019 14:52:02 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 12 Nov 2019 14:52:00 +0800 From: Chunfeng Yun To: Greg Kroah-Hartman , Felipe Balbi Subject: [PATCH v2 01/13] media: uvcvideo: drop error check of debugfs_create_dir() Date: Tue, 12 Nov 2019 14:51:47 +0800 Message-ID: <1573541519-28488-1-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_225229_147633_87475DFE X-CRM114-Status: GOOD ( 12.98 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 MIME_BASE64_TEXT RAW: Message text disguised using base64 encoding 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , Alexandre Belloni , "Gustavo A. R. Silva" , Yangtao Li , linux-kernel@vger.kernel.org, Minas Harutyunyan , Laurent Pinchart , Fabio Estevam , Florian Fainelli , Robert Jarzmik , Kevin Cernekee , Ludovic Desroches , bcm-kernel-feedback-list@broadcom.com, NXP Linux Team , Chunfeng Yun , Cristian Birsan , linux-media@vger.kernel.org, Fabrizio Castro , Sascha Hauer , Haojian Zhuang , Stephen Boyd , linux-mediatek@lists.infradead.org, Matthias Brugger , Mauro Carvalho Chehab , Bin Liu , linux-arm-kernel@lists.infradead.org, Biju Das , Yoshihiro Shimoda , linux-usb@vger.kernel.org, Pengutronix Kernel Team , Colin Ian King , Shawn Guo , Daniel Mack Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No need check the return value of debugfs_create_dir() Signed-off-by: Chunfeng Yun --- v2: 1. abandon new API usb_debugfs_create_dir(), and drop error check --- drivers/media/usb/uvc/uvc_debugfs.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_debugfs.c b/drivers/media/usb/uvc/uvc_debugfs.c index d2b109959d82..2b8af4b54117 100644 --- a/drivers/media/usb/uvc/uvc_debugfs.c +++ b/drivers/media/usb/uvc/uvc_debugfs.c @@ -108,15 +108,7 @@ void uvc_debugfs_cleanup_stream(struct uvc_streaming *stream) void uvc_debugfs_init(void) { - struct dentry *dir; - - dir = debugfs_create_dir("uvcvideo", usb_debug_root); - if (IS_ERR_OR_NULL(dir)) { - uvc_printk(KERN_INFO, "Unable to create debugfs directory\n"); - return; - } - - uvc_debugfs_root_dir = dir; + uvc_debugfs_root_dir = debugfs_create_dir("uvcvideo", usb_debug_root); } void uvc_debugfs_cleanup(void)