From patchwork Tue Nov 12 10:04:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 11238975 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6199815AB for ; Tue, 12 Nov 2019 10:06:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40E3C21783 for ; Tue, 12 Nov 2019 10:06:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40E3C21783 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:60996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUT3j-0003TY-7n for patchwork-qemu-devel@patchwork.kernel.org; Tue, 12 Nov 2019 05:06:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53120) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUT2b-0001xA-3z for qemu-devel@nongnu.org; Tue, 12 Nov 2019 05:04:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUT2Z-0002N3-T5 for qemu-devel@nongnu.org; Tue, 12 Nov 2019 05:04:53 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:39405) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUT2T-0002Jc-Tv; Tue, 12 Nov 2019 05:04:47 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N94qX-1hrg712Gut-016BOh; Tue, 12 Nov 2019 11:04:36 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 3/5] numa: Add missing \n to error message Date: Tue, 12 Nov 2019 11:04:27 +0100 Message-Id: <20191112100429.11957-4-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191112100429.11957-1-laurent@vivier.eu> References: <20191112100429.11957-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:1vcYrg0+LvVV941g910cFpeztGR7BbLAIO4J2uy2+wndIDdXaqX QQrjHxwlfvMTyxg5ZHj7I6FD8ugA72K1CyyF3hdKSNfJvri6dhS0lWF42+ECl2VvoDnBaEU 858sIynsaHEflh3H8tkIP/UBhFDJFsMUb8l9Np3rUAZ59VmfVMwQDzlxT+GdbklddAW+GHQ 0SdzzT/ZHB4EmowG/MDcQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:RSABOG9S6a4=:a++67xUUz3yi+zUuQ4SHMl 5A9bYM1q3ecd02KSjezcnWNuNWs995RQcYwi7nhXafur6+Bl0OkpuM41yLSpey4VOthrKR1eO TlRe7oYjLjAMh3kcdHtZACpp5guZt4OFhJm03HXhXpnWjIINR2FzxLdproVH2pq1POFbQjbbX DLQw8QVE35bFb+XPQzHWOXm5uAUpZmKzZaSvpllxABSU7PUoZ/SC6pBUeDnKbCnro1gNMUrPe mj7LmAUxOcq9f9Xgwck2JJ7n7lP/0mtzBJsklYOi3V4kAxrHrBZCn+Q699Ctj1XYOUySUHF8q jrGMqzm8Kg7o/ds/3xJNQEyphgwfYf5bGPzHPqZJh5xtouUQrO3Z6P8gvtJ9DLQwlzDKBkOXr dvcxOT+Ukz7tWjQt8MtWj16ffMXggfKLVWPI79SmL4nJI7dLe1Eg5VO96C6n3zhY8iciDgNMA /vurNAi4++vWlQwsuJguV1rJMIG+KdGZHZL9L/Lf/a0CoAzDG00N+jUryaIdKqacjwbKJiqMc HWmy2EsQ3efU2TKgnYzMxv63OmXJo3MVYHVfoBx0IfKl0klAnqotpoaEdZWLuEja38kwZ2Tef s+OkGNCGUb2BXyJ51qXs2XMYXvtS30KGaZiZwf5ZE1b4aL4NTw/bK+5NYscouaeVNJELjjcIj YjGd3vSM+RWHcPwurSVNHo723tpMpLb0yO1Zcw+d/uVn1tJbf7R45S9f54XzLQfDGkch0cEhb wvWUH/B5zVtKrvLAg0cBCGiG4MmOllUpisTBJ/cqecK2SVnv8gnWTEg/8o7C3CkOFQvL/1bmU 5yuds2xffULaULGc69vW8tk7vm/f5RJ0808OolE41Mp4gXwgRtnj+LDuGDsTTXaIn8Goe3GWF Pyk3kqXJcdc9HXmkXORaGFdKP9iOk3fJt0qt6vtGc= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.72.192.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Greg Kurz , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Greg Kurz If memory allocation fails when using -mem-path, QEMU is supposed to print out a message to indicate that fallback to anonymous RAM is deprecated. This is done with error_printf() which does output buffering. As a consequence, the message is only printed at the next flush, eg. when quiting QEMU, and it also lacks a trailing newline: qemu-system-ppc64: unable to map backing store for guest RAM: Cannot allocate memory qemu-system-ppc64: warning: falling back to regular RAM allocation QEMU 4.1.50 monitor - type 'help' for more information (qemu) q This is deprecated. Make sure that -mem-path specified path has sufficient resources to allocate -m specified RAM amountgreg@boss02:~/Work/qemu/qemu-spapr$ Add the missing \n to fix both issues. Fixes: cb79224b7e4b "deprecate -mem-path fallback to anonymous RAM" Signed-off-by: Greg Kurz Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: <157304440026.351774.14607704217028190097.stgit@bahia.lan> Signed-off-by: Laurent Vivier --- hw/core/numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index 038c96d4abc6..e3332a984f7c 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -503,7 +503,7 @@ static void allocate_system_memory_nonnuma(MemoryRegion *mr, Object *owner, warn_report("falling back to regular RAM allocation"); error_printf("This is deprecated. Make sure that -mem-path " " specified path has sufficient resources to allocate" - " -m specified RAM amount"); + " -m specified RAM amount\n"); /* Legacy behavior: if allocation failed, fall back to * regular RAM allocation. */