[1/5] btrfs: decrement number of open devices after closing the device not before
diff mbox series

Message ID 20191112122416.30672-2-jthumshirn@suse.de
State New
Headers show
  • [1/5] btrfs: decrement number of open devices after closing the device not before
Related show

Commit Message

Johannes Thumshirn Nov. 12, 2019, 12:24 p.m. UTC
In btrfs_close_one_device we're decrementing the number of open devices
before we're calling btrfs_close_bdev().

As there is no intermediate exit between these points in this function it
is technically OK to do so, but it a) is a bit harder to understand and b)
further refactoring to implement proper error handling in
btrfs_close_one_device() will change the layout of the function.

Move both operations closer together and move the decrement step after

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
 fs/btrfs/volumes.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff mbox series

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 22a5bd991e47..5ee26e7fca32 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -1067,9 +1067,6 @@  static void btrfs_close_one_device(struct btrfs_device *device)
 	struct btrfs_device *new_device;
 	struct rcu_string *name;
-	if (device->bdev)
-		fs_devices->open_devices--;
 	if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state) &&
 	    device->devid != BTRFS_DEV_REPLACE_DEVID) {
@@ -1080,6 +1077,8 @@  static void btrfs_close_one_device(struct btrfs_device *device)
+	if (device->bdev)
+		fs_devices->open_devices--;
 	new_device = btrfs_alloc_device(NULL, &device->devid,