ASoC: Jack: Fix NULL pointer dereference in snd_soc_jack_report
diff mbox series

Message ID 20191112130237.10141-1-pawel.harlozinski@linux.intel.com
State Accepted
Commit 8f157d4ff039e03e2ed4cb602eeed2fd4687a58f
Headers show
Series
  • ASoC: Jack: Fix NULL pointer dereference in snd_soc_jack_report
Related show

Commit Message

Harlozinski, Pawel Nov. 12, 2019, 1:02 p.m. UTC
Check for existance of jack before tracing.
NULL pointer dereference has been reported by KASAN while unloading
machine driver (snd_soc_cnl_rt274).

Signed-off-by: Pawel Harlozinski <pawel.harlozinski@linux.intel.com>

---
 sound/soc/soc-jack.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Patch
diff mbox series

diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c
index a71d2340eb05..b5748dcd490f 100644
--- a/sound/soc/soc-jack.c
+++ b/sound/soc/soc-jack.c
@@ -82,10 +82,9 @@  void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask)
 	unsigned int sync = 0;
 	int enable;
 
-	trace_snd_soc_jack_report(jack, mask, status);
-
 	if (!jack)
 		return;
+	trace_snd_soc_jack_report(jack, mask, status);
 
 	dapm = &jack->card->dapm;