nfsd: v4 support requires CRYPTO_SHA256
diff mbox series

Message ID 20191112190155.12872-1-smayhew@redhat.com
State New
Headers show
Series
  • nfsd: v4 support requires CRYPTO_SHA256
Related show

Commit Message

Scott Mayhew Nov. 12, 2019, 7:01 p.m. UTC
The new nfsdcld client tracking operations use sha256 to compute hashes
of the kerberos principals, so make sure CRYPTO_SHA256 is enabled.

Fixes: 6ee95d1c8991 ("nfsd: add support for upcall version 2")
Reported-by: Jamie Heilman <jamie@audible.transient.net>
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
 fs/nfsd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chuck Lever Nov. 12, 2019, 7:07 p.m. UTC | #1
> On Nov 12, 2019, at 2:01 PM, Scott Mayhew <smayhew@redhat.com> wrote:
> 
> The new nfsdcld client tracking operations use sha256 to compute hashes
> of the kerberos principals, so make sure CRYPTO_SHA256 is enabled.
> 
> Fixes: 6ee95d1c8991 ("nfsd: add support for upcall version 2")
> Reported-by: Jamie Heilman <jamie@audible.transient.net>
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>

I recently noticed this too in passing. I didn't have a chance to
give a thought about exactly how to address it, but this looks OK
to me.


> ---
> fs/nfsd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
> index 10cefb0c07c7..c4b1a89b8845 100644
> --- a/fs/nfsd/Kconfig
> +++ b/fs/nfsd/Kconfig
> @@ -73,7 +73,7 @@ config NFSD_V4
> 	select NFSD_V3
> 	select FS_POSIX_ACL
> 	select SUNRPC_GSS
> -	select CRYPTO
> +	select CRYPTO_SHA256
> 	select GRACE_PERIOD
> 	help
> 	  This option enables support in your system's NFS server for
> -- 
> 2.17.2
> 

--
Chuck Lever
J. Bruce Fields Nov. 12, 2019, 8 p.m. UTC | #2
Thanks, applied.--b.

On Tue, Nov 12, 2019 at 02:01:55PM -0500, Scott Mayhew wrote:
> The new nfsdcld client tracking operations use sha256 to compute hashes
> of the kerberos principals, so make sure CRYPTO_SHA256 is enabled.
> 
> Fixes: 6ee95d1c8991 ("nfsd: add support for upcall version 2")
> Reported-by: Jamie Heilman <jamie@audible.transient.net>
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
>  fs/nfsd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
> index 10cefb0c07c7..c4b1a89b8845 100644
> --- a/fs/nfsd/Kconfig
> +++ b/fs/nfsd/Kconfig
> @@ -73,7 +73,7 @@ config NFSD_V4
>  	select NFSD_V3
>  	select FS_POSIX_ACL
>  	select SUNRPC_GSS
> -	select CRYPTO
> +	select CRYPTO_SHA256
>  	select GRACE_PERIOD
>  	help
>  	  This option enables support in your system's NFS server for
> -- 
> 2.17.2

Patch
diff mbox series

diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
index 10cefb0c07c7..c4b1a89b8845 100644
--- a/fs/nfsd/Kconfig
+++ b/fs/nfsd/Kconfig
@@ -73,7 +73,7 @@  config NFSD_V4
 	select NFSD_V3
 	select FS_POSIX_ACL
 	select SUNRPC_GSS
-	select CRYPTO
+	select CRYPTO_SHA256
 	select GRACE_PERIOD
 	help
 	  This option enables support in your system's NFS server for