| Message ID | 20191112213310.212925-4-preichl@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfs: remove several typedefs in quota code | expand |
On Tue, Nov 12, 2019 at 10:33:08PM +0100, Pavel Reichl wrote: > Signed-off-by: Pavel Reichl <preichl@redhat.com> Looks good to me, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > fs/xfs/xfs_dquot.c | 2 +- > fs/xfs/xfs_dquot.h | 2 +- > fs/xfs/xfs_dquot_item.h | 10 +++++----- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c > index 5b089afd7087..4df8ffb9906f 100644 > --- a/fs/xfs/xfs_dquot.c > +++ b/fs/xfs/xfs_dquot.c > @@ -1018,7 +1018,7 @@ xfs_qm_dqflush_done( > struct xfs_buf *bp, > struct xfs_log_item *lip) > { > - xfs_dq_logitem_t *qip = (struct xfs_dq_logitem *)lip; > + struct xfs_dq_logitem *qip = (struct xfs_dq_logitem *)lip; > struct xfs_dquot *dqp = qip->qli_dquot; > struct xfs_ail *ailp = lip->li_ailp; > > diff --git a/fs/xfs/xfs_dquot.h b/fs/xfs/xfs_dquot.h > index 831e4270cf65..fe3e46df604b 100644 > --- a/fs/xfs/xfs_dquot.h > +++ b/fs/xfs/xfs_dquot.h > @@ -40,7 +40,7 @@ struct xfs_dquot { > xfs_fileoff_t q_fileoffset; > > struct xfs_disk_dquot q_core; > - xfs_dq_logitem_t q_logitem; > + struct xfs_dq_logitem q_logitem; > /* total regular nblks used+reserved */ > xfs_qcnt_t q_res_bcount; > /* total inos allocd+reserved */ > diff --git a/fs/xfs/xfs_dquot_item.h b/fs/xfs/xfs_dquot_item.h > index 1aed34ccdabc..3a64a7fd3b8a 100644 > --- a/fs/xfs/xfs_dquot_item.h > +++ b/fs/xfs/xfs_dquot_item.h > @@ -11,11 +11,11 @@ struct xfs_trans; > struct xfs_mount; > struct xfs_qoff_logitem; > > -typedef struct xfs_dq_logitem { > - struct xfs_log_item qli_item; /* common portion */ > - struct xfs_dquot *qli_dquot; /* dquot ptr */ > - xfs_lsn_t qli_flush_lsn; /* lsn at last flush */ > -} xfs_dq_logitem_t; > +struct xfs_dq_logitem { > + struct xfs_log_item qli_item; /* common portion */ > + struct xfs_dquot *qli_dquot; /* dquot ptr */ > + xfs_lsn_t qli_flush_lsn; /* lsn at last flush */ > +}; > > typedef struct xfs_qoff_logitem { > struct xfs_log_item qql_item; /* common portion */ > -- > 2.23.0 >
On Tue, Nov 12, 2019 at 10:33:08PM +0100, Pavel Reichl wrote: > Signed-off-by: Pavel Reichl <preichl@redhat.com> > --- > fs/xfs/xfs_dquot.c | 2 +- > fs/xfs/xfs_dquot.h | 2 +- > fs/xfs/xfs_dquot_item.h | 10 +++++----- > 3 files changed, 7 insertions(+), 7 deletions(-) Pretty sure I've already reviewed this, but simple enough to look at again. :) Looks good. Reviewed-by: Dave Chinner <dchinner@redhat.com>
Yes Dave, but IIRC the patch failed to apply cleanly so I had to use the -3way option and I got the idea that me merging code manually voids your ACK :-) On Thu, Nov 14, 2019 at 2:30 AM Dave Chinner <david@fromorbit.com> wrote: > > On Tue, Nov 12, 2019 at 10:33:08PM +0100, Pavel Reichl wrote: > > Signed-off-by: Pavel Reichl <preichl@redhat.com> > > --- > > fs/xfs/xfs_dquot.c | 2 +- > > fs/xfs/xfs_dquot.h | 2 +- > > fs/xfs/xfs_dquot_item.h | 10 +++++----- > > 3 files changed, 7 insertions(+), 7 deletions(-) > > Pretty sure I've already reviewed this, but simple enough to look at > again. :) > > Looks good. > > Reviewed-by: Dave Chinner <dchinner@redhat.com> > > -- > Dave Chinner > david@fromorbit.com >
On Thu, Nov 14, 2019 at 06:30:25AM +0100, Pavel Reichl wrote: > Yes Dave, but IIRC the patch failed to apply cleanly so I had to use > the -3way option and I got the idea that me merging code manually > voids your ACK :-) It depends. If the code itself is unchanged and it's just merge noise, then updating doesn't invalidate the review. If you had to change the code/logic because it no longer worked, then it's fair to ask for it to be reviewed again. :) Cheers, Dave.
diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c index 5b089afd7087..4df8ffb9906f 100644 --- a/fs/xfs/xfs_dquot.c +++ b/fs/xfs/xfs_dquot.c @@ -1018,7 +1018,7 @@ xfs_qm_dqflush_done( struct xfs_buf *bp, struct xfs_log_item *lip) { - xfs_dq_logitem_t *qip = (struct xfs_dq_logitem *)lip; + struct xfs_dq_logitem *qip = (struct xfs_dq_logitem *)lip; struct xfs_dquot *dqp = qip->qli_dquot; struct xfs_ail *ailp = lip->li_ailp; diff --git a/fs/xfs/xfs_dquot.h b/fs/xfs/xfs_dquot.h index 831e4270cf65..fe3e46df604b 100644 --- a/fs/xfs/xfs_dquot.h +++ b/fs/xfs/xfs_dquot.h @@ -40,7 +40,7 @@ struct xfs_dquot { xfs_fileoff_t q_fileoffset; struct xfs_disk_dquot q_core; - xfs_dq_logitem_t q_logitem; + struct xfs_dq_logitem q_logitem; /* total regular nblks used+reserved */ xfs_qcnt_t q_res_bcount; /* total inos allocd+reserved */ diff --git a/fs/xfs/xfs_dquot_item.h b/fs/xfs/xfs_dquot_item.h index 1aed34ccdabc..3a64a7fd3b8a 100644 --- a/fs/xfs/xfs_dquot_item.h +++ b/fs/xfs/xfs_dquot_item.h @@ -11,11 +11,11 @@ struct xfs_trans; struct xfs_mount; struct xfs_qoff_logitem; -typedef struct xfs_dq_logitem { - struct xfs_log_item qli_item; /* common portion */ - struct xfs_dquot *qli_dquot; /* dquot ptr */ - xfs_lsn_t qli_flush_lsn; /* lsn at last flush */ -} xfs_dq_logitem_t; +struct xfs_dq_logitem { + struct xfs_log_item qli_item; /* common portion */ + struct xfs_dquot *qli_dquot; /* dquot ptr */ + xfs_lsn_t qli_flush_lsn; /* lsn at last flush */ +}; typedef struct xfs_qoff_logitem { struct xfs_log_item qql_item; /* common portion */
Signed-off-by: Pavel Reichl <preichl@redhat.com> --- fs/xfs/xfs_dquot.c | 2 +- fs/xfs/xfs_dquot.h | 2 +- fs/xfs/xfs_dquot_item.h | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-)