Message ID | 20191112223600.30993-1-chris@chris-wilson.co.uk (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [1/4] drm/i915/gt: Set unused mocs entry to follow PTE on tgl as on all others | expand |
Chris Wilson <chris@chris-wilson.co.uk> writes: > Be consistent in our mocs setup on Tigerlake and set the unused control > value to follow the PTE entry as we previously have done. The unused > values are beyond the defines of the ABI, the consistency simplifies our > checking. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/intel_mocs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c > index 6e881c735b20..d2b445d6c258 100644 > --- a/drivers/gpu/drm/i915/gt/intel_mocs.c > +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c > @@ -489,7 +489,7 @@ static void intel_mocs_init_global(struct intel_gt *gt) > for (; index < table.n_entries; index++) > intel_uncore_write(uncore, > GEN12_GLOBAL_MOCS(index), > - table.table[0].control_value); > + table.table[I915_MOCS_PTE].control_value); > } > > void intel_mocs_init(struct intel_gt *gt) > -- > 2.24.0
Chris Wilson <chris@chris-wilson.co.uk> writes: > Be consistent in our mocs setup on Tigerlake and set the unused control > value to follow the PTE entry as we previously have done. The unused > values are beyond the defines of the ABI, the consistency simplifies our > checking. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/intel_mocs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c > index 6e881c735b20..d2b445d6c258 100644 > --- a/drivers/gpu/drm/i915/gt/intel_mocs.c > +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c > @@ -489,7 +489,7 @@ static void intel_mocs_init_global(struct intel_gt *gt) > for (; index < table.n_entries; index++) > intel_uncore_write(uncore, > GEN12_GLOBAL_MOCS(index), > - table.table[0].control_value); > + table.table[I915_MOCS_PTE].control_value); > } > > void intel_mocs_init(struct intel_gt *gt) > -- > 2.24.0
diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c index 6e881c735b20..d2b445d6c258 100644 --- a/drivers/gpu/drm/i915/gt/intel_mocs.c +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c @@ -489,7 +489,7 @@ static void intel_mocs_init_global(struct intel_gt *gt) for (; index < table.n_entries; index++) intel_uncore_write(uncore, GEN12_GLOBAL_MOCS(index), - table.table[0].control_value); + table.table[I915_MOCS_PTE].control_value); } void intel_mocs_init(struct intel_gt *gt)
Be consistent in our mocs setup on Tigerlake and set the unused control value to follow the PTE entry as we previously have done. The unused values are beyond the defines of the ABI, the consistency simplifies our checking. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gt/intel_mocs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)