[1/2] xfs: removed unused typedef definitions
diff mbox series

Message ID 3e3ddc13-4417-a0b1-85d1-a03a37a46461@sandeen.net
State Accepted
Headers show
Series
  • xfs: removed unused typedef definitions and symbols
Related show

Commit Message

Eric Sandeen Nov. 12, 2019, 10:59 p.m. UTC
Remove some typdefs for type_t's that are no longer referred to
by their typedef'd types.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Comments

Darrick J. Wong Nov. 13, 2019, 4:42 a.m. UTC | #1
On Tue, Nov 12, 2019 at 04:59:31PM -0600, Eric Sandeen wrote:
> Remove some typdefs for type_t's that are no longer referred to
> by their typedef'd types.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks ok, have fun cleaning them out of xfsprogs. ;)

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
> index c968b60cee15..8f6b485a3119 100644
> --- a/fs/xfs/libxfs/xfs_format.h
> +++ b/fs/xfs/libxfs/xfs_format.h
> @@ -920,13 +920,13 @@ static inline uint xfs_dinode_size(int version)
>   * This enum is used in string mapping in xfs_trace.h; please keep the
>   * TRACE_DEFINE_ENUMs for it up to date.
>   */
> -typedef enum xfs_dinode_fmt {
> +enum xfs_dinode_fmt {
>  	XFS_DINODE_FMT_DEV,		/* xfs_dev_t */
>  	XFS_DINODE_FMT_LOCAL,		/* bulk data */
>  	XFS_DINODE_FMT_EXTENTS,		/* struct xfs_bmbt_rec */
>  	XFS_DINODE_FMT_BTREE,		/* struct xfs_bmdr_block */
>  	XFS_DINODE_FMT_UUID		/* added long ago, but never used */
> -} xfs_dinode_fmt_t;
> +};
>  
>  #define XFS_INODE_FORMAT_STR \
>  	{ XFS_DINODE_FMT_DEV,		"dev" }, \
> diff --git a/fs/xfs/libxfs/xfs_log_recover.h b/fs/xfs/libxfs/xfs_log_recover.h
> index f3d18eaecebb..3bf671637a91 100644
> --- a/fs/xfs/libxfs/xfs_log_recover.h
> +++ b/fs/xfs/libxfs/xfs_log_recover.h
> @@ -30,14 +30,14 @@ typedef struct xlog_recover_item {
>  	xfs_log_iovec_t		*ri_buf;	/* ptr to regions buffer */
>  } xlog_recover_item_t;
>  
> -typedef struct xlog_recover {
> +struct xlog_recover {
>  	struct hlist_node	r_list;
>  	xlog_tid_t		r_log_tid;	/* log's transaction id */
>  	xfs_trans_header_t	r_theader;	/* trans header for partial */
>  	int			r_state;	/* not needed */
>  	xfs_lsn_t		r_lsn;		/* xact lsn */
>  	struct list_head	r_itemq;	/* q for items */
> -} xlog_recover_t;
> +};
>  
>  #define ITEM_TYPE(i)	(*(unsigned short *)(i)->ri_buf[0].i_addr)
>  
> diff --git a/fs/xfs/xfs_ioctl32.h b/fs/xfs/xfs_ioctl32.h
> index 7985344d3aa6..13b1d4b967bb 100644
> --- a/fs/xfs/xfs_ioctl32.h
> +++ b/fs/xfs/xfs_ioctl32.h
> @@ -99,7 +99,7 @@ typedef struct compat_xfs_fsop_handlereq {
>  	_IOWR('X', 108, struct compat_xfs_fsop_handlereq)
>  
>  /* The bstat field in the swapext struct needs translation */
> -typedef struct compat_xfs_swapext {
> +struct compat_xfs_swapext {
>  	int64_t			sx_version;	/* version */
>  	int64_t			sx_fdtarget;	/* fd of target file */
>  	int64_t			sx_fdtmp;	/* fd of tmp file */
> @@ -107,7 +107,7 @@ typedef struct compat_xfs_swapext {
>  	xfs_off_t		sx_length;	/* leng from offset */
>  	char			sx_pad[16];	/* pad space, unused */
>  	struct compat_xfs_bstat	sx_stat;	/* stat of target b4 copy */
> -} __compat_packed compat_xfs_swapext_t;
> +} __compat_packed;
>  
>  #define XFS_IOC_SWAPEXT_32	_IOWR('X', 109, struct compat_xfs_swapext)
>  
> 
>

Patch
diff mbox series

diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
index c968b60cee15..8f6b485a3119 100644
--- a/fs/xfs/libxfs/xfs_format.h
+++ b/fs/xfs/libxfs/xfs_format.h
@@ -920,13 +920,13 @@  static inline uint xfs_dinode_size(int version)
  * This enum is used in string mapping in xfs_trace.h; please keep the
  * TRACE_DEFINE_ENUMs for it up to date.
  */
-typedef enum xfs_dinode_fmt {
+enum xfs_dinode_fmt {
 	XFS_DINODE_FMT_DEV,		/* xfs_dev_t */
 	XFS_DINODE_FMT_LOCAL,		/* bulk data */
 	XFS_DINODE_FMT_EXTENTS,		/* struct xfs_bmbt_rec */
 	XFS_DINODE_FMT_BTREE,		/* struct xfs_bmdr_block */
 	XFS_DINODE_FMT_UUID		/* added long ago, but never used */
-} xfs_dinode_fmt_t;
+};
 
 #define XFS_INODE_FORMAT_STR \
 	{ XFS_DINODE_FMT_DEV,		"dev" }, \
diff --git a/fs/xfs/libxfs/xfs_log_recover.h b/fs/xfs/libxfs/xfs_log_recover.h
index f3d18eaecebb..3bf671637a91 100644
--- a/fs/xfs/libxfs/xfs_log_recover.h
+++ b/fs/xfs/libxfs/xfs_log_recover.h
@@ -30,14 +30,14 @@  typedef struct xlog_recover_item {
 	xfs_log_iovec_t		*ri_buf;	/* ptr to regions buffer */
 } xlog_recover_item_t;
 
-typedef struct xlog_recover {
+struct xlog_recover {
 	struct hlist_node	r_list;
 	xlog_tid_t		r_log_tid;	/* log's transaction id */
 	xfs_trans_header_t	r_theader;	/* trans header for partial */
 	int			r_state;	/* not needed */
 	xfs_lsn_t		r_lsn;		/* xact lsn */
 	struct list_head	r_itemq;	/* q for items */
-} xlog_recover_t;
+};
 
 #define ITEM_TYPE(i)	(*(unsigned short *)(i)->ri_buf[0].i_addr)
 
diff --git a/fs/xfs/xfs_ioctl32.h b/fs/xfs/xfs_ioctl32.h
index 7985344d3aa6..13b1d4b967bb 100644
--- a/fs/xfs/xfs_ioctl32.h
+++ b/fs/xfs/xfs_ioctl32.h
@@ -99,7 +99,7 @@  typedef struct compat_xfs_fsop_handlereq {
 	_IOWR('X', 108, struct compat_xfs_fsop_handlereq)
 
 /* The bstat field in the swapext struct needs translation */
-typedef struct compat_xfs_swapext {
+struct compat_xfs_swapext {
 	int64_t			sx_version;	/* version */
 	int64_t			sx_fdtarget;	/* fd of target file */
 	int64_t			sx_fdtmp;	/* fd of tmp file */
@@ -107,7 +107,7 @@  typedef struct compat_xfs_swapext {
 	xfs_off_t		sx_length;	/* leng from offset */
 	char			sx_pad[16];	/* pad space, unused */
 	struct compat_xfs_bstat	sx_stat;	/* stat of target b4 copy */
-} __compat_packed compat_xfs_swapext_t;
+} __compat_packed;
 
 #define XFS_IOC_SWAPEXT_32	_IOWR('X', 109, struct compat_xfs_swapext)