[2/2] xfs: remove unused structure members & simple typedefs
diff mbox series

Message ID 9b291c94-2961-3c11-22e4-556220758a9c@sandeen.net
State Accepted
Headers show
Series
  • xfs: removed unused typedef definitions and symbols
Related show

Commit Message

Eric Sandeen Nov. 12, 2019, 11:01 p.m. UTC
Remove some unused typedef'd simple types, and some unused 
structure members.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Comments

Darrick J. Wong Nov. 13, 2019, 4:41 a.m. UTC | #1
On Tue, Nov 12, 2019 at 05:01:43PM -0600, Eric Sandeen wrote:
> Remove some unused typedef'd simple types, and some unused 
> structure members.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
> diff --git a/fs/xfs/libxfs/xfs_types.h b/fs/xfs/libxfs/xfs_types.h
> index 300b3e91ca3a..397d94775440 100644
> --- a/fs/xfs/libxfs/xfs_types.h
> +++ b/fs/xfs/libxfs/xfs_types.h
> @@ -21,7 +21,6 @@ typedef int32_t		xfs_suminfo_t;	/* type of bitmap summary info */
>  typedef uint32_t	xfs_rtword_t;	/* word type for bitmap manipulations */
>  
>  typedef int64_t		xfs_lsn_t;	/* log sequence number */
> -typedef int32_t		xfs_tid_t;	/* transaction identifier */
>  
>  typedef uint32_t	xfs_dablk_t;	/* dir/attr block number (in file) */
>  typedef uint32_t	xfs_dahash_t;	/* dir/attr hash value */
> @@ -33,7 +32,6 @@ typedef uint64_t	xfs_fileoff_t;	/* block number in a file */
>  typedef uint64_t	xfs_filblks_t;	/* number of blocks in a file */
>  
>  typedef int64_t		xfs_srtblock_t;	/* signed version of xfs_rtblock_t */
> -typedef int64_t		xfs_sfiloff_t;	/* signed block number in a file */
>  
>  /*
>   * New verifiers will return the instruction address of the failing check.
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index b880c23cb6e4..ca0f0de5feb9 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -399,8 +399,6 @@ struct xlog {
>  	/* The following field are used for debugging; need to hold icloglock */
>  #ifdef DEBUG
>  	void			*l_iclog_bak[XLOG_MAX_ICLOGS];
> -	/* log record crc error injection factor */
> -	uint32_t		l_badcrc_factor;
>  #endif
>  	/* log recovery lsn tracking (for buffer submission */
>  	xfs_lsn_t		l_recovery_lsn;
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index fdb60e09a9c5..ebba9a61f804 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -59,7 +59,6 @@ struct xfs_error_cfg {
>  
>  typedef struct xfs_mount {
>  	struct super_block	*m_super;
> -	xfs_tid_t		m_tid;		/* next unused tid for fs */
>  
>  	/*
>  	 * Bitsets of per-fs metadata that have been checked and/or are sick.
> 
>

Patch
diff mbox series

diff --git a/fs/xfs/libxfs/xfs_types.h b/fs/xfs/libxfs/xfs_types.h
index 300b3e91ca3a..397d94775440 100644
--- a/fs/xfs/libxfs/xfs_types.h
+++ b/fs/xfs/libxfs/xfs_types.h
@@ -21,7 +21,6 @@  typedef int32_t		xfs_suminfo_t;	/* type of bitmap summary info */
 typedef uint32_t	xfs_rtword_t;	/* word type for bitmap manipulations */
 
 typedef int64_t		xfs_lsn_t;	/* log sequence number */
-typedef int32_t		xfs_tid_t;	/* transaction identifier */
 
 typedef uint32_t	xfs_dablk_t;	/* dir/attr block number (in file) */
 typedef uint32_t	xfs_dahash_t;	/* dir/attr hash value */
@@ -33,7 +32,6 @@  typedef uint64_t	xfs_fileoff_t;	/* block number in a file */
 typedef uint64_t	xfs_filblks_t;	/* number of blocks in a file */
 
 typedef int64_t		xfs_srtblock_t;	/* signed version of xfs_rtblock_t */
-typedef int64_t		xfs_sfiloff_t;	/* signed block number in a file */
 
 /*
  * New verifiers will return the instruction address of the failing check.
diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
index b880c23cb6e4..ca0f0de5feb9 100644
--- a/fs/xfs/xfs_log_priv.h
+++ b/fs/xfs/xfs_log_priv.h
@@ -399,8 +399,6 @@  struct xlog {
 	/* The following field are used for debugging; need to hold icloglock */
 #ifdef DEBUG
 	void			*l_iclog_bak[XLOG_MAX_ICLOGS];
-	/* log record crc error injection factor */
-	uint32_t		l_badcrc_factor;
 #endif
 	/* log recovery lsn tracking (for buffer submission */
 	xfs_lsn_t		l_recovery_lsn;
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
index fdb60e09a9c5..ebba9a61f804 100644
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -59,7 +59,6 @@  struct xfs_error_cfg {
 
 typedef struct xfs_mount {
 	struct super_block	*m_super;
-	xfs_tid_t		m_tid;		/* next unused tid for fs */
 
 	/*
 	 * Bitsets of per-fs metadata that have been checked and/or are sick.