[v2,4/4] ARM: dts: phycore-imx6: set buck regulator modes explicitly
diff mbox series

Message ID 1573652416-9848-5-git-send-email-chf.fritz@googlemail.com
State New
Headers show
Series
  • regulator da9062: support setting buck modes
Related show

Commit Message

Christoph Fritz Nov. 13, 2019, 1:40 p.m. UTC
This patch sets initial buck regulator modes explicitly to a state this
hardware needs. So a wrong initial mode set by bootloader or pmic itself
does not interfere anymore.

Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Adam Thomson Nov. 13, 2019, 4:26 p.m. UTC | #1
On 13 November 2019 13:40, Christoph Fritz wrote:

> This patch sets initial buck regulator modes explicitly to a state this
> hardware needs. So a wrong initial mode set by bootloader or pmic itself
> does not interfere anymore.
> 
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> ---
>  arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> index 6486df3..644625d 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -5,6 +5,7 @@
>   */
> 
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/regulator/dlg,da9063-regulator.h>
> 
>  / {
>  	aliases {
> @@ -109,6 +110,7 @@
>  				regulator-name = "vdd_arm";
>  				regulator-min-microvolt = <730000>;
>  				regulator-max-microvolt = <1380000>;
> +				regulator-initial-mode =
> <DA9063_BUCK_MODE_SYNC>;
>  				regulator-always-on;
>  			};
> 
> @@ -116,6 +118,7 @@
>  				regulator-name = "vdd_soc";
>  				regulator-min-microvolt = <730000>;
>  				regulator-max-microvolt = <1380000>;
> +				regulator-initial-mode =
> <DA9063_BUCK_MODE_SYNC>;
>  				regulator-always-on;
>  			};
> 
> @@ -123,6 +126,7 @@
>  				regulator-name = "vdd_ddr3";
>  				regulator-min-microvolt = <1500000>;
>  				regulator-max-microvolt = <1500000>;
> +				regulator-initial-mode =
> <DA9063_BUCK_MODE_SYNC>;
>  				regulator-always-on;
>  			};
> 
> @@ -130,6 +134,7 @@
>  				regulator-name = "vdd_eth";
>  				regulator-min-microvolt = <1200000>;
>  				regulator-max-microvolt = <1200000>;
> +				regulator-initial-mode =
> <DA9063_BUCK_MODE_SYNC>;
>  				regulator-always-on;
>  			};
> 
> --
> 2.1.4
Christoph Fritz Nov. 28, 2019, 8:30 p.m. UTC | #2
Hi Shawn,

 any chance to get this patch queued for the upcoming kernel?

bye
 -- Christoph

On Wed, 2019-11-13 at 16:26 +0000, Adam Thomson wrote:
> On 13 November 2019 13:40, Christoph Fritz wrote:
> 
> > This patch sets initial buck regulator modes explicitly to a state this
> > hardware needs. So a wrong initial mode set by bootloader or pmic itself
> > does not interfere anymore.
> > 
> > Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> 
> Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> 
> > ---
> >  arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > index 6486df3..644625d 100644
> > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > @@ -5,6 +5,7 @@
> >   */
> > 
> >  #include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/regulator/dlg,da9063-regulator.h>
> > 
> >  / {
> >  	aliases {
> > @@ -109,6 +110,7 @@
> >  				regulator-name = "vdd_arm";
> >  				regulator-min-microvolt = <730000>;
> >  				regulator-max-microvolt = <1380000>;
> > +				regulator-initial-mode =
> > <DA9063_BUCK_MODE_SYNC>;
> >  				regulator-always-on;
> >  			};
> > 
> > @@ -116,6 +118,7 @@
> >  				regulator-name = "vdd_soc";
> >  				regulator-min-microvolt = <730000>;
> >  				regulator-max-microvolt = <1380000>;
> > +				regulator-initial-mode =
> > <DA9063_BUCK_MODE_SYNC>;
> >  				regulator-always-on;
> >  			};
> > 
> > @@ -123,6 +126,7 @@
> >  				regulator-name = "vdd_ddr3";
> >  				regulator-min-microvolt = <1500000>;
> >  				regulator-max-microvolt = <1500000>;
> > +				regulator-initial-mode =
> > <DA9063_BUCK_MODE_SYNC>;
> >  				regulator-always-on;
> >  			};
> > 
> > @@ -130,6 +134,7 @@
> >  				regulator-name = "vdd_eth";
> >  				regulator-min-microvolt = <1200000>;
> >  				regulator-max-microvolt = <1200000>;
> > +				regulator-initial-mode =
> > <DA9063_BUCK_MODE_SYNC>;
> >  				regulator-always-on;
> >  			};
> > 
> > --
> > 2.1.4
>
Shawn Guo Dec. 4, 2019, 12:53 p.m. UTC | #3
On Thu, Nov 28, 2019 at 09:30:44PM +0100, Christoph Fritz wrote:
> Hi Shawn,
> 
>  any chance to get this patch queued for the upcoming kernel?

Sorry, no.  I need to wait for DA9063_BUCK_MODE_SYNC landing on 5.5-rc1,
and then apply this DTS patch.

Shawn

> 
> bye
>  -- Christoph
> 
> On Wed, 2019-11-13 at 16:26 +0000, Adam Thomson wrote:
> > On 13 November 2019 13:40, Christoph Fritz wrote:
> > 
> > > This patch sets initial buck regulator modes explicitly to a state this
> > > hardware needs. So a wrong initial mode set by bootloader or pmic itself
> > > does not interfere anymore.
> > > 
> > > Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> > 
> > Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> > 
> > > ---
> > >  arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > > b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > > index 6486df3..644625d 100644
> > > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > > @@ -5,6 +5,7 @@
> > >   */
> > > 
> > >  #include <dt-bindings/gpio/gpio.h>
> > > +#include <dt-bindings/regulator/dlg,da9063-regulator.h>
> > > 
> > >  / {
> > >  	aliases {
> > > @@ -109,6 +110,7 @@
> > >  				regulator-name = "vdd_arm";
> > >  				regulator-min-microvolt = <730000>;
> > >  				regulator-max-microvolt = <1380000>;
> > > +				regulator-initial-mode =
> > > <DA9063_BUCK_MODE_SYNC>;
> > >  				regulator-always-on;
> > >  			};
> > > 
> > > @@ -116,6 +118,7 @@
> > >  				regulator-name = "vdd_soc";
> > >  				regulator-min-microvolt = <730000>;
> > >  				regulator-max-microvolt = <1380000>;
> > > +				regulator-initial-mode =
> > > <DA9063_BUCK_MODE_SYNC>;
> > >  				regulator-always-on;
> > >  			};
> > > 
> > > @@ -123,6 +126,7 @@
> > >  				regulator-name = "vdd_ddr3";
> > >  				regulator-min-microvolt = <1500000>;
> > >  				regulator-max-microvolt = <1500000>;
> > > +				regulator-initial-mode =
> > > <DA9063_BUCK_MODE_SYNC>;
> > >  				regulator-always-on;
> > >  			};
> > > 
> > > @@ -130,6 +134,7 @@
> > >  				regulator-name = "vdd_eth";
> > >  				regulator-min-microvolt = <1200000>;
> > >  				regulator-max-microvolt = <1200000>;
> > > +				regulator-initial-mode =
> > > <DA9063_BUCK_MODE_SYNC>;
> > >  				regulator-always-on;
> > >  			};
> > > 
> > > --
> > > 2.1.4
> > 
> 
> 
>
Christoph Fritz Dec. 11, 2019, 6:56 p.m. UTC | #4
On Wed, 2019-12-04 at 20:53 +0800, Shawn Guo wrote:
> On Thu, Nov 28, 2019 at 09:30:44PM +0100, Christoph Fritz wrote:
> > Hi Shawn,
> > 
> >  any chance to get this patch queued for the upcoming kernel?
> 
> Sorry, no.  I need to wait for DA9063_BUCK_MODE_SYNC landing on 5.5-rc1,
> and then apply this DTS patch.


DA9063_BUCK_MODE_SYNC is now available in 5.5-rc1, could you queue this
patch now?
Shawn Guo Dec. 12, 2019, 1:41 a.m. UTC | #5
On Wed, Dec 11, 2019 at 07:56:26PM +0100, Christoph Fritz wrote:
> On Wed, 2019-12-04 at 20:53 +0800, Shawn Guo wrote:
> > On Thu, Nov 28, 2019 at 09:30:44PM +0100, Christoph Fritz wrote:
> > > Hi Shawn,
> > > 
> > >  any chance to get this patch queued for the upcoming kernel?
> > 
> > Sorry, no.  I need to wait for DA9063_BUCK_MODE_SYNC landing on 5.5-rc1,
> > and then apply this DTS patch.
> 
> 
> DA9063_BUCK_MODE_SYNC is now available in 5.5-rc1, could you queue this
> patch now?

Done.  Thanks for reminding.

Shawn

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
index 6486df3..644625d 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
@@ -5,6 +5,7 @@ 
  */
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/dlg,da9063-regulator.h>
 
 / {
 	aliases {
@@ -109,6 +110,7 @@ 
 				regulator-name = "vdd_arm";
 				regulator-min-microvolt = <730000>;
 				regulator-max-microvolt = <1380000>;
+				regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
 				regulator-always-on;
 			};
 
@@ -116,6 +118,7 @@ 
 				regulator-name = "vdd_soc";
 				regulator-min-microvolt = <730000>;
 				regulator-max-microvolt = <1380000>;
+				regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
 				regulator-always-on;
 			};
 
@@ -123,6 +126,7 @@ 
 				regulator-name = "vdd_ddr3";
 				regulator-min-microvolt = <1500000>;
 				regulator-max-microvolt = <1500000>;
+				regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
 				regulator-always-on;
 			};
 
@@ -130,6 +134,7 @@ 
 				regulator-name = "vdd_eth";
 				regulator-min-microvolt = <1200000>;
 				regulator-max-microvolt = <1200000>;
+				regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>;
 				regulator-always-on;
 			};