| Message ID | 20191113164434.254159-10-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,01/13] drm/modes: parse_cmdline: Fix possible reference past end of string | expand |
On Wed, Nov 13, 2019 at 05:44:31PM +0100, Hans de Goede wrote: > fb_get_options() will return fb_mode_option if no video=<connector-name> > argument is present on the kernel commandline, so there is no need to also > do this in drm_mode_parse_command_line_for_connector() as our only caller > uses fb_get_options() to get the mode_option argument. > > Changes in v2: > -Split out the changes dealing with the initialization of the mode struct > into a separate patch > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Maxime Ripard <mripard@kernel.org>
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 119fed7ab815..beb764efe6b3 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -1747,11 +1747,6 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option, mode->panel_orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN; -#ifdef CONFIG_FB - if (!mode_option) - mode_option = fb_mode_option; -#endif - if (!mode_option) { mode->specified = false; return false;
fb_get_options() will return fb_mode_option if no video=<connector-name> argument is present on the kernel commandline, so there is no need to also do this in drm_mode_parse_command_line_for_connector() as our only caller uses fb_get_options() to get the mode_option argument. Changes in v2: -Split out the changes dealing with the initialization of the mode struct into a separate patch Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/gpu/drm/drm_modes.c | 5 ----- 1 file changed, 5 deletions(-)