ath10k: qmi: Sleep for a while before assigning MSA memory
diff mbox series

Message ID 20191113233558.4040259-1-bjorn.andersson@linaro.org
State New
Headers show
Series
  • ath10k: qmi: Sleep for a while before assigning MSA memory
Related show

Commit Message

Bjorn Andersson Nov. 13, 2019, 11:35 p.m. UTC
Unless we sleep for a while before transitioning the MSA memory to WLAN
the MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1 firmware triggers a security
violation fairly reliably. Unforutnately recovering from this failure
always results in the entire system freezing.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 drivers/net/wireless/ath/ath10k/qmi.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Kalle Valo Nov. 15, 2019, 6:59 a.m. UTC | #1
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:

> Unless we sleep for a while before transitioning the MSA memory to WLAN
> the MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1 firmware triggers a security
> violation fairly reliably. Unforutnately recovering from this failure
> always results in the entire system freezing.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

b70b3a36ec33 ath10k: qmi: Sleep for a while before assigning MSA memory

Patch
diff mbox series

diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
index 637f83ef65f8..a0ba07b85362 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -773,6 +773,13 @@  static void ath10k_qmi_event_server_arrive(struct ath10k_qmi *qmi)
 	if (ret)
 		return;
 
+	/*
+	 * HACK: sleep for a while inbetween receiving the msa info response
+	 * and the XPU update to prevent SDM845 from crashing due to a security
+	 * violation, when running MPSS.AT.4.0.c2-01184-SDM845_GEN_PACK-1.
+	 */
+	msleep(20);
+
 	ret = ath10k_qmi_setup_msa_permissions(qmi);
 	if (ret)
 		return;