clk: ti: dra7-atl: Remove pm_runtime_irq_safe()
diff mbox series

Message ID 20191114101718.20619-1-peter.ujfalusi@ti.com
State New
Headers show
Series
  • clk: ti: dra7-atl: Remove pm_runtime_irq_safe()
Related show

Commit Message

Peter Ujfalusi Nov. 14, 2019, 10:17 a.m. UTC
This is not needed for anything, and prevents proper PM transitions for
parent devices which is bad in case of ti-sysc; this effectively kills
PM completely. Thus, remove the flag.

Suggested-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/clk/ti/clk-dra7-atl.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Tony Lindgren Nov. 14, 2019, 4:50 p.m. UTC | #1
* Peter Ujfalusi <peter.ujfalusi@ti.com> [191114 10:16]:
> This is not needed for anything, and prevents proper PM transitions for
> parent devices which is bad in case of ti-sysc; this effectively kills
> PM completely. Thus, remove the flag.

Good to hear and thanks for clearing this one:

Reviewed-by: Tony Lindgren <tony@atomide.com>
Stephen Boyd Jan. 6, 2020, 3:04 a.m. UTC | #2
Quoting Peter Ujfalusi (2019-11-14 02:17:18)
> This is not needed for anything, and prevents proper PM transitions for
> parent devices which is bad in case of ti-sysc; this effectively kills
> PM completely. Thus, remove the flag.
> 
> Suggested-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---

Applied to clk-fixes. Seems important to not ruin the PM experience.

Patch
diff mbox series

diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index f65e16c4f3c4..8d4c08b034bd 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -233,7 +233,6 @@  static int of_dra7_atl_clk_probe(struct platform_device *pdev)
 	cinfo->iobase = of_iomap(node, 0);
 	cinfo->dev = &pdev->dev;
 	pm_runtime_enable(cinfo->dev);
-	pm_runtime_irq_safe(cinfo->dev);
 
 	pm_runtime_get_sync(cinfo->dev);
 	atl_write(cinfo, DRA7_ATL_PCLKMUX_REG(0), DRA7_ATL_PCLKMUX);