crypto: sun4i-ss: use crypto_ahash_digestsize
diff mbox series

Message ID 20191114105813.13171-1-clabbe.montjoie@gmail.com
State Mainlined
Commit 626abd3125e02d75e26f3cd2e2aa4a6fb74507b5
Headers show
Series
  • crypto: sun4i-ss: use crypto_ahash_digestsize
Related show

Commit Message

Corentin Labbe Nov. 14, 2019, 10:58 a.m. UTC
The size of the digest is different between MD5 and SHA1 so instead of
using the higher value (5 words), let's use crypto_ahash_digestsize().

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Herbert Xu Nov. 22, 2019, 11:03 a.m. UTC | #1
On Thu, Nov 14, 2019 at 11:58:13AM +0100, Corentin Labbe wrote:
> The size of the digest is different between MD5 and SHA1 so instead of
> using the higher value (5 words), let's use crypto_ahash_digestsize().
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.

Patch
diff mbox series

diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c
index ee518dcdba42..ec5d9ce24bb8 100644
--- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c
+++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c
@@ -227,7 +227,7 @@  static int sun4i_hash(struct ahash_request *areq)
 	 */
 	if (op->byte_count) {
 		ivmode = SS_IV_ARBITRARY;
-		for (i = 0; i < 5; i++)
+		for (i = 0; i < crypto_ahash_digestsize(tfm) / 4; i++)
 			writel(op->hash[i], ss->base + SS_IV0 + i * 4);
 	}
 	/* Enable the device */