| Message ID | 1573736352-3597-1-git-send-email-eugen.hristev@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sdhci-of-at91: fix quirk2 overwrite | expand |
On 14/11/19 2:59 PM, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev <eugen.hristev@microchip.com> > > The quirks2 are parsed and set (e.g. from DT) before the quirk for broken > HS200 is set in the driver. > The driver needs to enable just this flag, not rewrite the whole quirk set. > > Fixes: 7871aa60ae00 ("mmc: sdhci-of-at91: add quirk for broken HS200") > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > > drivers/mmc/host/sdhci-of-at91.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index 496844a..5fe6684 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -389,7 +389,7 @@ static int sdhci_at91_probe(struct platform_device *pdev) > pm_runtime_use_autosuspend(&pdev->dev); > > /* HS200 is broken at this moment */ > - host->quirks2 = SDHCI_QUIRK2_BROKEN_HS200; > + host->quirks2 |= SDHCI_QUIRK2_BROKEN_HS200; > > ret = sdhci_add_host(host); > if (ret) >
On Thu, 14 Nov 2019 at 13:59, <Eugen.Hristev@microchip.com> wrote: > > From: Eugen Hristev <eugen.hristev@microchip.com> > > The quirks2 are parsed and set (e.g. from DT) before the quirk for broken > HS200 is set in the driver. > The driver needs to enable just this flag, not rewrite the whole quirk set. > > Fixes: 7871aa60ae00 ("mmc: sdhci-of-at91: add quirk for broken HS200") > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> Applied for fixes, adding a stable tag, thanks! Kind regards Uffe > --- > > drivers/mmc/host/sdhci-of-at91.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index 496844a..5fe6684 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -389,7 +389,7 @@ static int sdhci_at91_probe(struct platform_device *pdev) > pm_runtime_use_autosuspend(&pdev->dev); > > /* HS200 is broken at this moment */ > - host->quirks2 = SDHCI_QUIRK2_BROKEN_HS200; > + host->quirks2 |= SDHCI_QUIRK2_BROKEN_HS200; > > ret = sdhci_add_host(host); > if (ret) > -- > 2.7.4 >
diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index 496844a..5fe6684 100644 --- a/drivers/mmc/host/sdhci-of-at91.c +++ b/drivers/mmc/host/sdhci-of-at91.c @@ -389,7 +389,7 @@ static int sdhci_at91_probe(struct platform_device *pdev) pm_runtime_use_autosuspend(&pdev->dev); /* HS200 is broken at this moment */ - host->quirks2 = SDHCI_QUIRK2_BROKEN_HS200; + host->quirks2 |= SDHCI_QUIRK2_BROKEN_HS200; ret = sdhci_add_host(host); if (ret)