[4.4.y-cip,05/21] clk: shmobile: Compile clk-rcar-gen2.c when using the r8a7744
diff mbox series

Message ID 1573737877-11733-6-git-send-email-biju.das@bp.renesas.com
State Accepted
Headers show
Series
  • Add iWave RZ/G1N support
Related show

Commit Message

Biju Das Nov. 14, 2019, 1:24 p.m. UTC
This patch makes sure clk-rcar-gen2,c gets compiled when
CONFIG_ARCH_R8A7744 is selected, similarly to what done by
commit:
7bac4ad3e40f ("CIP: Build essential clock driver for Renesas
RZ/G1 platforms")

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 drivers/clk/shmobile/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Pavel Machek Nov. 15, 2019, 9:17 p.m. UTC | #1
Hi!

> > > > > +++ b/drivers/clk/shmobile/Makefile
> > > > > @@ -3,6 +3,7 @@ obj-$(CONFIG_ARCH_R7S72100)		+=
> > clk-rz.o
> > > > >  obj-$(CONFIG_ARCH_R8A73A4)		+= clk-r8a73a4.o
> > > > >  obj-$(CONFIG_ARCH_R8A7740)		+= clk-r8a7740.o
> > > > >  obj-$(CONFIG_ARCH_R8A7743)		+= clk-rcar-gen2.o
> > > > > +obj-$(CONFIG_ARCH_R8A7744)		+= clk-rcar-gen2.o
> > > > >  obj-$(CONFIG_ARCH_R8A7745)		+= clk-rcar-gen2.o
> > > > >  obj-$(CONFIG_ARCH_R8A77470)		+= clk-rcar-gen2.o
> > > > >  obj-$(CONFIG_ARCH_R8A7778)		+= clk-r8a7778.o
> > > >
> > > > This is kind-of interesting code. I'm okay with merging it as-is,
> > > > but would it be possible to select more suitable config option so
> > > > that same object file is not included 4 times?
> > >
> > > What about the others on the same file?
> > > 11 obj-$(CONFIG_ARCH_R8A7790)              += clk-rcar-gen2.o
> > >  12 obj-$(CONFIG_ARCH_R8A7791)              += clk-rcar-gen2.o
> > >  13 obj-$(CONFIG_ARCH_R8A7793)              += clk-rcar-gen2.o
> > >  14 obj-$(CONFIG_ARCH_R8A7794)              += clk-rcar-gen2.o
> > 
> > Could these all be replaced with
> > 
> > obj-$(CONFIG_ARCH_RCAR_GEN2)              += clk-rcar-gen2.o
> 
> On the mainline it is modified like this. Do you want me to backport the relevant changes or are you happy to do this? Please let me know.
> obj-$(CONFIG_CLK_RCAR_GEN2)             += clk-rcar-gen2.o

If it is easy, please backport relevant changes. If it is not, it can
stay this way.

Best regards,
								Pavel

Patch
diff mbox series

diff --git a/drivers/clk/shmobile/Makefile b/drivers/clk/shmobile/Makefile
index 2412eb9..6badac5 100644
--- a/drivers/clk/shmobile/Makefile
+++ b/drivers/clk/shmobile/Makefile
@@ -3,6 +3,7 @@  obj-$(CONFIG_ARCH_R7S72100)		+= clk-rz.o
 obj-$(CONFIG_ARCH_R8A73A4)		+= clk-r8a73a4.o
 obj-$(CONFIG_ARCH_R8A7740)		+= clk-r8a7740.o
 obj-$(CONFIG_ARCH_R8A7743)		+= clk-rcar-gen2.o
+obj-$(CONFIG_ARCH_R8A7744)		+= clk-rcar-gen2.o
 obj-$(CONFIG_ARCH_R8A7745)		+= clk-rcar-gen2.o
 obj-$(CONFIG_ARCH_R8A77470)		+= clk-rcar-gen2.o
 obj-$(CONFIG_ARCH_R8A7778)		+= clk-r8a7778.o