[2/4] t/gitweb-lib.sh: drop confusing quotes
diff mbox series

Message ID 20191115090601.GB21987@sigill.intra.peff.net
State New
Headers show
Series
  • gitweb: quote base url more consistently
Related show

Commit Message

Jeff King Nov. 15, 2019, 9:06 a.m. UTC
Some variables assignments in gitweb_run() look like this:

  FOO=""$1""

The extra quotes aren't doing anything. Each set opens and closes an
empty string, and $1 is actually outside of any double-quotes (which is
OK, because variable assignment does not do whitespace splitting on the
expanded value).

Let's drop them, as they're simply confusing.

Signed-off-by: Jeff King <peff@peff.net>
---
 t/gitweb-lib.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch
diff mbox series

diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
index 006d2a8152..130c7ed64f 100644
--- a/t/gitweb-lib.sh
+++ b/t/gitweb-lib.sh
@@ -58,8 +58,8 @@  gitweb_run () {
 	GATEWAY_INTERFACE='CGI/1.1'
 	HTTP_ACCEPT='*/*'
 	REQUEST_METHOD='GET'
-	QUERY_STRING=""$1""
-	PATH_INFO=""$2""
+	QUERY_STRING=$1
+	PATH_INFO=$2
 	export GATEWAY_INTERFACE HTTP_ACCEPT REQUEST_METHOD \
 		QUERY_STRING PATH_INFO