[v1] media: venus: firmware: Use %pR to print IO resource
diff mbox series

Message ID 20191115143044.55512-1-andriy.shevchenko@linux.intel.com
State New
Headers show
Series
  • [v1] media: venus: firmware: Use %pR to print IO resource
Related show

Commit Message

Andy Shevchenko Nov. 15, 2019, 2:30 p.m. UTC
Replace explicit use of members of struct resource by %pR to print
the resource.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/platform/qcom/venus/firmware.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Andy Shevchenko Jan. 8, 2020, 1:37 p.m. UTC | #1
On Fri, Nov 15, 2019 at 04:30:44PM +0200, Andy Shevchenko wrote:
> Replace explicit use of members of struct resource by %pR to print
> the resource.

Any comment on this?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/platform/qcom/venus/firmware.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
> index d3d1748a7ef6..de6812fb55f4 100644
> --- a/drivers/media/platform/qcom/venus/firmware.c
> +++ b/drivers/media/platform/qcom/venus/firmware.c
> @@ -100,8 +100,7 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
>  
>  	mem_va = memremap(r.start, *mem_size, MEMREMAP_WC);
>  	if (!mem_va) {
> -		dev_err(dev, "unable to map memory region: %pa+%zx\n",
> -			&r.start, *mem_size);
> +		dev_err(dev, "unable to map memory region: %pR\n", &r);
>  		ret = -ENOMEM;
>  		goto err_release_fw;
>  	}
> -- 
> 2.24.0
>
Stanimir Varbanov Jan. 8, 2020, 2:02 p.m. UTC | #2
Hi Andy,

Thanks for the patch!

On 11/15/19 4:30 PM, Andy Shevchenko wrote:
> Replace explicit use of members of struct resource by %pR to print
> the resource.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/platform/qcom/venus/firmware.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

> 
> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
> index d3d1748a7ef6..de6812fb55f4 100644
> --- a/drivers/media/platform/qcom/venus/firmware.c
> +++ b/drivers/media/platform/qcom/venus/firmware.c
> @@ -100,8 +100,7 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
>  
>  	mem_va = memremap(r.start, *mem_size, MEMREMAP_WC);
>  	if (!mem_va) {
> -		dev_err(dev, "unable to map memory region: %pa+%zx\n",
> -			&r.start, *mem_size);
> +		dev_err(dev, "unable to map memory region: %pR\n", &r);
>  		ret = -ENOMEM;
>  		goto err_release_fw;
>  	}
>

Patch
diff mbox series

diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
index d3d1748a7ef6..de6812fb55f4 100644
--- a/drivers/media/platform/qcom/venus/firmware.c
+++ b/drivers/media/platform/qcom/venus/firmware.c
@@ -100,8 +100,7 @@  static int venus_load_fw(struct venus_core *core, const char *fwname,
 
 	mem_va = memremap(r.start, *mem_size, MEMREMAP_WC);
 	if (!mem_va) {
-		dev_err(dev, "unable to map memory region: %pa+%zx\n",
-			&r.start, *mem_size);
+		dev_err(dev, "unable to map memory region: %pR\n", &r);
 		ret = -ENOMEM;
 		goto err_release_fw;
 	}