| Message ID | 20191117101545.6406-1-matwey@sai.msu.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board | expand |
Hi Matwey, Am Sonntag, 17. November 2019, 11:15:37 CET schrieb Matwey V. Kornilov: > Radxa Rock Pi 4 is equipped with M.2 PCIe slot, > so enable PCIe for the board. > > The changes has been tested with Intel SSD 660p series device. > > 01:00.0 Class 0108: Device 8086:f1a8 (rev 03) > > Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru> applied the patch, but you could do a follow-up that mimics https://lore.kernel.org/linux-arm-kernel/20191117140728.917-1-linux.amoon@gmail.com/ aka find out from the schematics where the 0.9 and 1.8 supplies come from. Thanks Heiko
пн, 18 нояб. 2019 г. в 03:46, Heiko Stuebner <heiko@sntech.de>: > > Hi Matwey, > > Am Sonntag, 17. November 2019, 11:15:37 CET schrieb Matwey V. Kornilov: > > Radxa Rock Pi 4 is equipped with M.2 PCIe slot, > > so enable PCIe for the board. > > > > The changes has been tested with Intel SSD 660p series device. > > > > 01:00.0 Class 0108: Device 8086:f1a8 (rev 03) > > > > Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru> > > applied the patch, but you could do a follow-up that mimics > https://lore.kernel.org/linux-arm-kernel/20191117140728.917-1-linux.amoon@gmail.com/ > > aka find out from the schematics where the 0.9 and 1.8 supplies come from. Current schematics (https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi4_v13_sch_20181112.pdf) is controversial on 1.8 supply: On sheet 15 it says that 1.8 is supplied by VCC_1V8 at the same time on sheet 3 it says that it is supplied by VCCA_1V8 > > Thanks > Heiko > >
Hi, Matwey On Tue, Nov 19, 2019 at 2:41 AM Matwey V. Kornilov <matwey.kornilov@gmail.com> wrote: > > Current schematics > (https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi4_v13_sch_20181112.pdf) > is controversial on 1.8 supply: > > On sheet 15 it says that 1.8 is supplied by VCC_1V8 > at the same time on sheet 3 it says that it is supplied by VCCA_1V8 I am sorry for the confusion of the schematic. Please ignore the power tree on sheet 3, it's from the original reference design, I think we have different power paths on ROCK Pi 4. Please refer the circuits starting from sheet 5 below. It reflects the real hardware. We will fix the power tree and upload a new version of the schematic. > > > > > Thanks > > Heiko > > > > > > > -- > With best regards, > Matwey V. Kornilov > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts index 1ae1ebd4efdd..01f8effd8206 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts @@ -463,6 +463,21 @@ pmu1830-supply = <&vcc_3v0>; }; +&pcie_phy { + status = "okay"; +}; + +&pcie0 { + status = "okay"; + + ep-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_HIGH>; + max-link-speed = <2>; + num-lanes = <4>; + pinctrl-0 = <&pcie_clkreqnb_cpm>; + pinctrl-names = "default"; + vpcie3v3-supply = <&vcc3v3_pcie>; +}; + &pinctrl { bt { bt_enable_h: bt-enable-h {
Radxa Rock Pi 4 is equipped with M.2 PCIe slot, so enable PCIe for the board. The changes has been tested with Intel SSD 660p series device. 01:00.0 Class 0108: Device 8086:f1a8 (rev 03) Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru> --- Changes since v1: - add vpcie3v3-supply arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)