[RFC,2/4] dt-bindings: net: Add compatible for BCM4335A0 bluetooth module
diff mbox series

Message ID 20191117175606.5050-3-mohammad.rasim96@gmail.com
State Superseded
Headers show
Series
  • add support for videostrong KII Pro
Related show

Commit Message

Mohammad Rasim Nov. 17, 2019, 5:56 p.m. UTC
Available in the Ampak AP6335 WiFi/Bluetooth combo

Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
---
 Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Neil Armstrong Nov. 18, 2019, 10:03 a.m. UTC | #1
Hi,

On 17/11/2019 18:56, Mohammad Rasim wrote:
> 
> Available in the Ampak AP6335 WiFi/Bluetooth combo
> 
> Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
> ---
>  Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> index 4fa00e2eafcf..0717399191a2 100644
> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> @@ -14,6 +14,7 @@ Required properties:
>     * "brcm,bcm4330-bt"
>     * "brcm,bcm43438-bt"
>     * "brcm,bcm4345c5"
> +   * "brcm,bcm4335a0"

Is there a specific reason to add a new compatible here ? it the BT interface of the BCM4335A0 different for the actual compatible modules ?

If not, simply use a common "brcm,bcm43438-bt" compatible string.

Neil

>  
>  Optional properties:
>  
>
Mohammad Rasim Nov. 18, 2019, 5:53 p.m. UTC | #2
On 19/11/18 11:03AM, Neil Armstrong wrote:
> Hi,
> 
> On 17/11/2019 18:56, Mohammad Rasim wrote:
> > 
> > Available in the Ampak AP6335 WiFi/Bluetooth combo
> > 
> > Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > index 4fa00e2eafcf..0717399191a2 100644
> > --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > @@ -14,6 +14,7 @@ Required properties:
> >     * "brcm,bcm4330-bt"
> >     * "brcm,bcm43438-bt"
> >     * "brcm,bcm4345c5"
> > +   * "brcm,bcm4335a0"
> 
> Is there a specific reason to add a new compatible here ? it the BT interface of the BCM4335A0 different for the actual compatible modules ?
>
> If not, simply use a common "brcm,bcm43438-bt" compatible string.
I added a new compatible so that the dts of the device can describe the
exact model of the module, anyone reading the dts might think that the
device has a bcm43438 module which is incorrect and just looks weird to
me.
previous compatibles like 'bcm4330-bt' are only used for probing and
don't appear to be used anywhere else so I guess this is ok by the
bluetooth maintainers, if not I will use a previous compatible and add a
comment in the dts with the exact model of the chip.

Regards
> 
> Neil
> 
> >  
> >  Optional properties:
> >  
> > 
>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
index 4fa00e2eafcf..0717399191a2 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
+++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
@@ -14,6 +14,7 @@  Required properties:
    * "brcm,bcm4330-bt"
    * "brcm,bcm43438-bt"
    * "brcm,bcm4345c5"
+   * "brcm,bcm4335a0"
 
 Optional properties: