ASoC: wm5100: add missed pm_runtime_disable
diff mbox series

Message ID 20191118073707.28298-1-hslester96@gmail.com
State Accepted
Commit b1176bbb70866f24099cd2720283c7219fb4a81c
Headers show
Series
  • ASoC: wm5100: add missed pm_runtime_disable
Related show

Commit Message

Chuhong Yuan Nov. 18, 2019, 7:37 a.m. UTC
The driver forgets to call pm_runtime_disable in remove and
probe failure.
Add the calls to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
 sound/soc/codecs/wm5100.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Charles Keepax Nov. 18, 2019, 11:47 a.m. UTC | #1
On Mon, Nov 18, 2019 at 03:37:07PM +0800, Chuhong Yuan wrote:
> The driver forgets to call pm_runtime_disable in remove and
> probe failure.
> Add the calls to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

Patch
diff mbox series

diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c
index 4af0e519e623..91cc63c5a51f 100644
--- a/sound/soc/codecs/wm5100.c
+++ b/sound/soc/codecs/wm5100.c
@@ -2617,6 +2617,7 @@  static int wm5100_i2c_probe(struct i2c_client *i2c,
 	return ret;
 
 err_reset:
+	pm_runtime_disable(&i2c->dev);
 	if (i2c->irq)
 		free_irq(i2c->irq, wm5100);
 	wm5100_free_gpio(i2c);
@@ -2640,6 +2641,7 @@  static int wm5100_i2c_remove(struct i2c_client *i2c)
 {
 	struct wm5100_priv *wm5100 = i2c_get_clientdata(i2c);
 
+	pm_runtime_disable(&i2c->dev);
 	if (i2c->irq)
 		free_irq(i2c->irq, wm5100);
 	wm5100_free_gpio(i2c);