From patchwork Sun Nov 17 17:22:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 11249095 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4A27A1390 for ; Mon, 18 Nov 2019 08:37:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 322B6206A4 for ; Mon, 18 Nov 2019 08:37:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 322B6206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=umn.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A71BF89F49; Mon, 18 Nov 2019 08:36:59 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 592 seconds by postgrey-1.36 at gabe; Sun, 17 Nov 2019 17:32:49 UTC Received: from mta-p0.oit.umn.edu (mta-p0.oit.umn.edu [134.84.196.200]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78EEB8999E for ; Sun, 17 Nov 2019 17:32:49 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mta-p0.oit.umn.edu (Postfix) with ESMTP id 47GJnY17bRzcnV for ; Sun, 17 Nov 2019 17:22:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p0.oit.umn.edu ([127.0.0.1]) by localhost (mta-p0.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0hmVRNmvpR2r for ; Sun, 17 Nov 2019 11:22:57 -0600 (CST) Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p0.oit.umn.edu (Postfix) with ESMTPS id 47GJnX746HzbKx for ; Sun, 17 Nov 2019 11:22:56 -0600 (CST) Received: by mail-yb1-f200.google.com with SMTP id u10so10528414ybj.17 for ; Sun, 17 Nov 2019 09:22:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RIby2qRx5cEwNIrcIoDIHdDJ6ejQhdeyp3owCLM8obk=; b=XBIeP4gsfCFCHdxVqLkulfHmB5z/JyOj9gnzuEngc8jAPUM46CMS0efAo6ti1GOkUn pZasFCtmYS75whZyXnx38nnDyyHhk1RIhPRGQmhSudLe2eIN64upZAd4IRX7fjlfZOFH 0B7aW7B3k0Q/tsf9LHw9X6eoSb2bPN4LKC9Z0uGJwkRtcv8Kw3953YmJdzFnjtJShDOG 33CkxBefbT5nZD5cSNATGR+gChxQ7OAxg2253JU9KuccNGqOIETcC/NoRGiNho0LqaOQ k+81TWSxHkh3cMM5D2GnMPzaedW5+Wy4/HlAf9TVEroAy06cPPSnrVdvJRZJhVSPvjAa J4cQ== X-Gm-Message-State: APjAAAUuks3UhQJ3nxXtZchHvqJ6/zIUd9n9qWGSqj5yDhEvOb7/LjKV YVj+pOoN/pguSowlQvZO3ydqmEiHDBg/RhvDwJznBEGVNHGnwww9fOqUXPryLQXwjH2zlD3ZT9j ZrA0DFtb4HRALaP4grCWUmFO84w78FlAe X-Received: by 2002:a81:71c4:: with SMTP id m187mr16741540ywc.327.1574011375501; Sun, 17 Nov 2019 09:22:55 -0800 (PST) X-Google-Smtp-Source: APXvYqwRSZyGvEeTEQTqYLBwcl2GMjbN83a4HUDRBI+2xrk9iViMa5K8z+axNVTrtuWEQ1cR/lc6Mw== X-Received: by 2002:a81:71c4:: with SMTP id m187mr16741510ywc.327.1574011375242; Sun, 17 Nov 2019 09:22:55 -0800 (PST) Received: from cs-u-syssec1.dtc.umn.edu (cs-u-syssec1.cs.umn.edu. [128.101.106.66]) by smtp.gmail.com with ESMTPSA id 124sm6654970ywo.98.2019.11.17.09.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Nov 2019 09:22:54 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Subject: [PATCH] drm/amd/display: Fix error returned by program_hpd_filter Date: Sun, 17 Nov 2019 11:22:34 -0600 Message-Id: <20191117172236.2140-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Mon, 18 Nov 2019 08:36:58 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=RIby2qRx5cEwNIrcIoDIHdDJ6ejQhdeyp3owCLM8obk=; b=IRanUKstwT1MnUfDW4znsizornJMbx0pRICZZKzplIGIiA3OJ+MupXA0DK7QXt6M9c hLWZAgq6YTjDz4dClo6XI8qh6O0AEshigJzSARu8dQPCU/R2YI+MPH1d8HMEVvptX2LP 2CqovGn7TmSCS387hLEScYeCaCvqJ7vdrnljOcqfc19SjC6HnDNMpXbGuCNHzOtb4iDh bzFKDt1m+gnvDulkJgW4pgrRQ6i895IiisubEZ7hz9iMljjm1AQWK17ZTWMch9u/EvYT NccpkOgcjITRXlYagZbOT2+7he8di4ZPpkTv9UfOdlWEinhxUTaz056LWuOkx75Bq4gO mg0A== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Chris Park , Eric Yang , Leo Li , Bhawanpreet Lakha , David Francis , kjlu@umn.edu, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Nikola Cornij , David Airlie , Eric Bernstein , David Galiffi , Alex Deucher , Wenjing Liu , Jun Lei , =?utf-8?q?Christian_K=C3=B6nig?= , Anthony Koo MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" program_hpd_filter() currently fails to check for the errors returned in construct(). This patch returns error in case of failure. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c index ca20b150afcc..bbb648a50c41 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c @@ -1379,9 +1379,8 @@ static bool construct( * If GPIO isn't programmed correctly HPD might not rise or drain * fast enough, leading to bounces. */ - program_hpd_filter(link); + return program_hpd_filter(link); - return true; device_tag_fail: link->link_enc->funcs->destroy(&link->link_enc); link_enc_create_fail: