diff mbox series

KVM: x86: Unexport kvm_vcpu_reload_apic_access_page()

Message ID 20191118172702.42200-1-liran.alon@oracle.com (mailing list archive)
State New, archived
Headers show
Series KVM: x86: Unexport kvm_vcpu_reload_apic_access_page() | expand

Commit Message

Liran Alon Nov. 18, 2019, 5:27 p.m. UTC 
The function is only used in kvm.ko module.

Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
---
 arch/x86/kvm/x86.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Vitaly Kuznetsov Nov. 19, 2019, 12:30 p.m. UTC | #1 
Liran Alon <liran.alon@oracle.com> writes:

> The function is only used in kvm.ko module.
>
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
>  arch/x86/kvm/x86.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index eb992f5d299f..7e7a0921d92a 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -7916,7 +7916,6 @@ void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
>  	 */
>  	put_page(page);
>  }
> -EXPORT_SYMBOL_GPL(kvm_vcpu_reload_apic_access_page);
>  
>  void __kvm_request_immediate_exit(struct kvm_vcpu *vcpu)
>  {

It doesn't seem that we need the declaration in
arch/x86/include/asm/kvm_host.h either (and the function can become
local). Anyway,

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Paolo Bonzini Nov. 19, 2019, 3:34 p.m. UTC | #2 
On 18/11/19 18:27, Liran Alon wrote:
> The function is only used in kvm.ko module.
> 
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> ---
>  arch/x86/kvm/x86.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index eb992f5d299f..7e7a0921d92a 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -7916,7 +7916,6 @@ void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
>  	 */
>  	put_page(page);
>  }
> -EXPORT_SYMBOL_GPL(kvm_vcpu_reload_apic_access_page);
>  
>  void __kvm_request_immediate_exit(struct kvm_vcpu *vcpu)
>  {
> 

Queued, thanks.

Paolo
diff mbox series

Patch

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index eb992f5d299f..7e7a0921d92a 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -7916,7 +7916,6 @@  void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
 	 */
 	put_page(page);
 }
-EXPORT_SYMBOL_GPL(kvm_vcpu_reload_apic_access_page);
 
 void __kvm_request_immediate_exit(struct kvm_vcpu *vcpu)
 {